Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45010 )
Change subject: soc/intel/skylake: Fix NHLT_PDM_DEV definition
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45010/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45010/3//COMMIT_MSG@7
PS3, Line 7: Fix NHLT_PDM_DEV definition
Sorry, but the change doesn't do this. […]
Ooooor simply add `config NHLT_PDM_DEV_VALUE`, make it default to zero, override it in KBL to be one, and use it to assign a value to NHLT_PDM_DEV.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45010
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbc67228c9e7af7db5154d597ca8d67860cfd2ed
Gerrit-Change-Number: 45010
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 24 Oct 2020 09:06:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment