Attention is currently required from: Paul Menzel, Patrick Rudolph. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62008 )
Change subject: drivers/intel/i210: Set log level to BIOS_NOTICE on missing MAC address ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62008/comment/11176adc_59b1aff5 PS1, Line 12:
Looks like only siemens/mc_apl1 and siemens/mc_ehl implement `mainboard_get_mac_address()`. […]
I do not see why the MAC address should be runtime configurable. We have a cbfs file where the MAC address is retrieved from (hwinfo.hex). If this file is missing or there is no valid MAC address inside it (all 0xFF or 0x00) then the MAC will not be programmed and therefore keeps its original address. This message is just to make aware that there is not valid address in hwinfo.hex and is not a hard error.