Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mb/clevo/n141cu: Add new Comet Lake mainboard ......................................................................
Patch Set 36:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 38: default "clevo/cml-u" : : config VARIANT_DIR : default "n141cu" : : config MAINBOARD_FAMILY : default "Comet Lake" :
Yes, the Clevo notebooks have a very similar layout and therefore we can sum up them by platform.
Ack, but when I wanted to do that for X11, many people were against that *shrug*
https://review.coreboot.org/c/coreboot/+/40581/36/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/40581/36/src/mainboard/clevo/cml-u/... PS36, Line 78: TPM_PIRQ probably missing