Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40414 )
Change subject: lib/spd_bin: add get_spd_sn function
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40414/6/src/soc/intel/common/block/...
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/40414/6/src/soc/intel/common/block/...
PS6, Line 119: } else if (dram_type == SPD_DRAM_DDR3)
If any branch of an if/else if/else has more than one statement and uses braces {}, then all branches need to use them as well.
https://review.coreboot.org/c/coreboot/+/40414/6/src/soc/intel/common/block/...
PS6, Line 126: }
nit: blank line after }
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40414
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I406bba7cc56debbd9851d430f069e4fb96ec937c
Gerrit-Change-Number: 40414
Gerrit-PatchSet: 6
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 May 2020 20:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment