Change in ...coreboot[master]: soc/intel/common/block/gpio: Fix the mask for gpio_pm_configure

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33099

Change subject: soc/intel/common/block/gpio: Fix the mask for gpio_pm_configure
......................................................................

soc/intel/common/block/gpio: Fix the mask for gpio_pm_configure

gpio_pm_configure clears out all the bits related to PM configuration
in MISCCFG register and sets only the bits requested by mainboard. The
mask as it is set currently results in preserving all PM bits instead
of clearing them. This change updates the mask to ensure that the PM
bits are cleared before setting the ones requested by mainboard.

Change-Id: I5b8c04952775dc1e94fa229328be2f3c1102a468
Signed-off-by: Furquan Shaikh 
---
M src/soc/intel/common/block/gpio/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/33099/1

diff --git a/src/soc/intel/common/block/gpio/gpio.c b/src/soc/intel/common/block/gpio/gpio.c
index d37601c..7ebf05a 100644
--- a/src/soc/intel/common/block/gpio/gpio.c
+++ b/src/soc/intel/common/block/gpio/gpio.c
@@ -615,7 +615,7 @@
 {
    int i;
    size_t gpio_communities;
-	uint8_t misccfg_pm_mask = MISCCFG_ENABLE_GPIO_PM_CONFIG;
+	const uint8_t misccfg_pm_mask = ~MISCCFG_ENABLE_GPIO_PM_CONFIG;
    const struct pad_community *comm;

comm = soc_gpio_get_community(&gpio_communities);

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33099 )

Change subject: soc/intel/common/block/gpio: Fix the mask for gpio_pm_configure
......................................................................

Patch Set 1: Code-Review+2

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33099 )

Change subject: soc/intel/common/block/gpio: Fix the mask for gpio_pm_configure
......................................................................

Patch Set 1: Code-Review+2

const FTW

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33099 )

Change subject: soc/intel/common/block/gpio: Fix the mask for gpio_pm_configure
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33099 )

Change subject: soc/intel/common/block/gpio: Fix the mask for gpio_pm_configure
......................................................................

soc/intel/common/block/gpio: Fix the mask for gpio_pm_configure

gpio_pm_configure clears out all the bits related to PM configuration
in MISCCFG register and sets only the bits requested by mainboard. The
mask as it is set currently results in preserving all PM bits instead
of clearing them. This change updates the mask to ensure that the PM
bits are cleared before setting the ones requested by mainboard.

Change-Id: I5b8c04952775dc1e94fa229328be2f3c1102a468
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33099
Tested-by: build bot (Jenkins) 
Reviewed-by: Subrata Banik 
Reviewed-by: Paul Fagerburg 
Reviewed-by: Tim Wawrzynczak 
---
M src/soc/intel/common/block/gpio/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Subrata Banik: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved
  Paul Fagerburg: Looks good to me, approved

diff --git a/src/soc/intel/common/block/gpio/gpio.c b/src/soc/intel/common/block/gpio/gpio.c
index d37601c..7ebf05a 100644
--- a/src/soc/intel/common/block/gpio/gpio.c
+++ b/src/soc/intel/common/block/gpio/gpio.c
@@ -615,7 +615,7 @@
 {
    int i;
    size_t gpio_communities;
-	uint8_t misccfg_pm_mask = MISCCFG_ENABLE_GPIO_PM_CONFIG;
+	const uint8_t misccfg_pm_mask = ~MISCCFG_ENABLE_GPIO_PM_CONFIG;
    const struct pad_community *comm;

comm = soc_gpio_get_community(&gpio_communities);