Attention is currently required from: V Sowmya, Martin Roth, Tim Wawrzynczak, Sugnan Prabhu S, Balaji Manigandan, Aamir Bohra.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49479 )
Change subject: mb/intel/shadowmountain: Add bootblock and verstage code
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/mainboard/intel/shadowmountain/Kconfig:
https://review.coreboot.org/c/coreboot/+/49479/comment/888b680a_6e2502e6
PS5, Line 24: default y
Please drop the `default y`. Otherwise, the `!CHROMEOS` configuration doesn't get build-tested.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49479
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f805baf42203306ff10e91a258d9117dd986c4a
Gerrit-Change-Number: 49479
Gerrit-PatchSet: 5
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Thu, 28 Jan 2021 09:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment