Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32838 )
Change subject: coreboot: Add new function die_with_post_code()
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/32838/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32838/1//COMMIT_MSG@7
PS1, Line 7: coreboot:
all or these patches are in coreboot, so this shouldn't be in the subject. Generally we want the area that's being affected - usually a directory.
I'd use "console:" here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32838
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87551d60b253dc13ff76f7898c1f112f573a00a2
Gerrit-Change-Number: 32838
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 May 2019 21:35:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment