Attention is currently required from: Martin Roth, Paul Menzel, Julius Werner, Ron Minnich, HAOUAS Elyes.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50966 )
Change subject: Documentation/coding_style: Issues not mentioned and cleanup patches
......................................................................
Patch Set 2:
(1 comment)
File Documentation/contributing/coding_style.md:
https://review.coreboot.org/c/coreboot/+/50966/comment/e6135839_d7c24cb0
PS2, Line 27: positives. They should not be bulk-applied to change existing code.)
To bulk-apply clang-format is exactly what would eliminate the discussions around style...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50966
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88efd5f1006bd1fd82cea14ea65422d9958dc197
Gerrit-Change-Number: 50966
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Ron Minnich
rminnich@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Ron Minnich
rminnich@google.com
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 22 Mar 2021 11:29:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment