Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52554 )
Change subject: soc/amd/picasso/chip.h: improve comments on downcore_mode ......................................................................
soc/amd/picasso/chip.h: improve comments on downcore_mode
Clarify that the downcoring is about deactivating physical cores.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ib8a9d1cedff995c507c3be72e7665953e1659238 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52554 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/chip.h 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/picasso/chip.h b/src/soc/amd/picasso/chip.h index e357f54..c70b89b 100644 --- a/src/soc/amd/picasso/chip.h +++ b/src/soc/amd/picasso/chip.h @@ -142,9 +142,9 @@
enum { DOWNCORE_AUTO = 0, - DOWNCORE_1 = 1, /* Run with single core */ - DOWNCORE_2 = 3, /* Run with two cores */ - DOWNCORE_3 = 4, /* Run with three cores */ + DOWNCORE_1 = 1, /* Run with 1 physical core */ + DOWNCORE_2 = 3, /* Run with 2 physical cores */ + DOWNCORE_3 = 4, /* Run with 3 physical cores */ } downcore_mode; bool smt_disable; /* true=disable SMT on all physical cores */