Attention is currently required from: Furquan Shaikh, Shou-Chieh Hsu, Karthik Ramasubramanian.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56685 )
Change subject: mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56685/comment/6cc8fddc_a5917871
PS6, Line 12: magister and magma
I am concerned if the impact is well understood across all Mag* devices with all possible RO/RW FW c […]
The other Mag* projects are under development stages,and haven't went to PVT stages. They can modify the ssfc value of the firmware change.
In current status, we only need to write SSFC for Elan6918 of Magister in production line. Other tocuhscreen devices have their own I2C slave address,and
using default value ssfc = 0x0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Gerrit-Change-Number: 56685
Gerrit-PatchSet: 7
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Henry Sun
henrysun@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 30 Jul 2021 02:19:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment