Attention is currently required from: Angel Pons, Arthur Heymans, Martin L Roth.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/82494?usp=email )
Change subject: treewide: Add generation of CFR Tables
......................................................................
Patch Set 7:
(1 comment)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/82494/comment/47e5ea9f_4e4fba86?usp... :
PS7, Line 568: __weak
why weak?
There is a use case on the prodrive atlas baord, that needs to update the SOT tables in runtime (so it needs to do more than this generic fetch from CBFS and put into CBMEM).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82494?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3408e9166139a95b7dcf4b151472a01951597133
Gerrit-Change-Number: 82494
Gerrit-PatchSet: 7
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 01 Jul 2024 12:11:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz