Change in coreboot[master]: {mb/facebook/fbg1701,mb/poertwell/m107}: Remove the power button from...

[Wim Vervoorn (Code Review)]

Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38134 )

Change subject: {mb/facebook/fbg1701,mb/poertwell/m107}: Remove the power button from ASL
......................................................................

{mb/facebook/fbg1701,mb/poertwell/m107}: Remove the power button from ASL

The mainboard ASL code contained a power button definition. This is not
required as the system uses the standard ACPI power button.

Remove the PWRB device from ASL.

BUG=N/A
TEST=build

Change-Id: I4fac1411fd99475551bc970818759649f80b3f0e
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/facebook/fbg1701/acpi/mainboard.asl
D src/mainboard/portwell/m107/acpi/mainboard.asl
M src/mainboard/portwell/m107/dsdt.asl
3 files changed, 1 insertion(+), 37 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/38134/1

diff --git a/src/mainboard/facebook/fbg1701/acpi/mainboard.asl b/src/mainboard/facebook/fbg1701/acpi/mainboard.asl
index af79bd7..e1f19b0 100644
--- a/src/mainboard/facebook/fbg1701/acpi/mainboard.asl
+++ b/src/mainboard/facebook/fbg1701/acpi/mainboard.asl
@@ -3,7 +3,7 @@
  *
  * Copyright (C) 2012 Google Inc.
  * Copyright (C) 2015 Intel Corp.
- * Copyright (C) 2018 Eltan B.V.
+ * Copyright (C) 2018-2020 Eltan B.V.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License as
@@ -16,15 +16,6 @@
  * GNU General Public License for more details.
  */

-Scope (_SB)
-{
-	Device (PWRB)
-	{
-		Name (_HID, EisaId ("PNP0C0C"))
-		Name (_UID, 1)
-	}
-}
-
 /*
  * Onboard CPLD
  */
diff --git a/src/mainboard/portwell/m107/acpi/mainboard.asl b/src/mainboard/portwell/m107/acpi/mainboard.asl
deleted file mode 100644
index 2c325c6..0000000
--- a/src/mainboard/portwell/m107/acpi/mainboard.asl
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2012 Google Inc.
- * Copyright (C) 2015 Intel Corp.
- * Copyright (C) 2018 Eltan B.V.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-Scope (_SB)
-{
-	Device (PWRB)
-	{
-		Name (_HID, EisaId ("PNP0C0C"))
-		Name (_UID, 1)
-	}
-}
diff --git a/src/mainboard/portwell/m107/dsdt.asl b/src/mainboard/portwell/m107/dsdt.asl
index 6fcb39a..ced3e10 100644
--- a/src/mainboard/portwell/m107/dsdt.asl
+++ b/src/mainboard/portwell/m107/dsdt.asl
@@ -45,5 +45,4 @@

/* Mainboard specific sleep states */
    #include "acpi/sleepstates.asl"
-	#include "acpi/mainboard.asl"
 }

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38134 )

Change subject: {mb/facebook/fbg1701,mb/poertwell/m107}: Remove the power button from ASL
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38134/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38134/1//COMMIT_MSG@7 
PS1, Line 7: {mb/facebook/fbg1701,mb/poertwell/m107}: Remove the power button from ASL
portwell
Suggestion: Remove PWRB from ASL

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Remove the PWRB device as sta...

[Wim Vervoorn (Code Review)]

Hello Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38134

to look at the new patch set (#2).

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Remove the PWRB device as standard power button is used
......................................................................

{mb/facebook/fbg1701,mb/portwell/m107}: Remove the PWRB device as standard power button is used

The mainboard ASL code contained a power button definition. This is not
required as the system uses the standard ACPI power button.

Remove the PWRB device from ASL.

BUG=N/A
TEST=build

Change-Id: I4fac1411fd99475551bc970818759649f80b3f0e
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/facebook/fbg1701/acpi/mainboard.asl
D src/mainboard/portwell/m107/acpi/mainboard.asl
M src/mainboard/portwell/m107/dsdt.asl
3 files changed, 1 insertion(+), 37 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/38134/2

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Remove the PWRB device as sta...

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38134 )

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Remove the PWRB device as standard power button is used
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38134/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38134/1//COMMIT_MSG@7 
PS1, Line 7: {mb/facebook/fbg1701,mb/poertwell/m107}: Remove the power button from ASL
> portwell […]

Done

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Remove the PWRB device as sta...

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38134 )

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Remove the PWRB device as standard power button is used
......................................................................

Patch Set 2: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/38134/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38134/2//COMMIT_MSG@7 
PS2, Line 7: {mb/facebook/fbg1701,mb/portwell/m107}: Remove the PWRB device as standard power button is used
mb/{facebook/fbg1701,portwell/m107}: Drop PWRB device

https://review.coreboot.org/c/coreboot/+/38134/2/src/mainboard/facebook/fbg1... 
File src/mainboard/facebook/fbg1701/acpi/mainboard.asl:

https://review.coreboot.org/c/coreboot/+/38134/2/src/mainboard/facebook/fbg1... 
PS2, Line 6: 2020
I am not a lawyer, but... what's there to claim copyright on?

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

[Wim Vervoorn (Code Review)]

Hello Angel Pons, Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38134

to look at the new patch set (#3).

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
......................................................................

{mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

The mainboard ASL code contained a power button definition. This is not
required as the system uses the standard ACPI power button.

Remove the PWRB device from ASL.

BUG=N/A
TEST=build

Change-Id: I4fac1411fd99475551bc970818759649f80b3f0e
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/facebook/fbg1701/acpi/mainboard.asl
D src/mainboard/portwell/m107/acpi/mainboard.asl
M src/mainboard/portwell/m107/dsdt.asl
3 files changed, 1 insertion(+), 37 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/38134/3

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

[Wim Vervoorn (Code Review)]

Hello Angel Pons, Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38134

to look at the new patch set (#4).

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
......................................................................

{mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

The mainboard ASL code contained a power button definition. This is not
required as the system uses the standard ACPI power button.

Remove the PWRB device from ASL.

BUG=N/A
TEST=build

Change-Id: I4fac1411fd99475551bc970818759649f80b3f0e
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/facebook/fbg1701/acpi/mainboard.asl
D src/mainboard/portwell/m107/acpi/mainboard.asl
M src/mainboard/portwell/m107/dsdt.asl
3 files changed, 0 insertions(+), 36 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/38134/4

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38134 )

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38134/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38134/2//COMMIT_MSG@7 
PS2, Line 7: {mb/facebook/fbg1701,mb/portwell/m107}: Remove the PWRB device as standard power button is used
> mb/{facebook/fbg1701,portwell/m107}: Drop PWRB device

Done

https://review.coreboot.org/c/coreboot/+/38134/2/src/mainboard/facebook/fbg1... 
File src/mainboard/facebook/fbg1701/acpi/mainboard.asl:

https://review.coreboot.org/c/coreboot/+/38134/2/src/mainboard/facebook/fbg1... 
PS2, Line 6: 2020
> I am not a lawyer, but... […]

You're right, removed it.

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38134 )

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38134 )

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
......................................................................

Patch Set 4: Code-Review+2

Thanks!

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38134 )

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38134/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38134/4//COMMIT_MSG@16 
PS4, Line 16: 
Found-by: fwts {version}

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

[Wim Vervoorn (Code Review)]

Hello Angel Pons, Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38134

to look at the new patch set (#5).

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
......................................................................

{mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

The mainboard ASL code contained a power button definition. This is not
required as the system uses the standard ACPI power button.

This issue can be found using fwts 19.12.00.

Remove the PWRB device from ASL.

BUG=N/A
TEST=build

Change-Id: I4fac1411fd99475551bc970818759649f80b3f0e
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/facebook/fbg1701/acpi/mainboard.asl
D src/mainboard/portwell/m107/acpi/mainboard.asl
M src/mainboard/portwell/m107/dsdt.asl
3 files changed, 0 insertions(+), 36 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/38134/5

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

[Wim Vervoorn (Code Review)]

Hello Angel Pons, Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38134

to look at the new patch set (#6).

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
......................................................................

{mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

The mainboard ASL code contained a power button definition. This is not
required as the system uses the standard ACPI power button.

Remove the PWRB device from ASL.

BUG=N/A
TEST=build

Found-by: fwts 19.12.00
Change-Id: I4fac1411fd99475551bc970818759649f80b3f0e
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/facebook/fbg1701/acpi/mainboard.asl
D src/mainboard/portwell/m107/acpi/mainboard.asl
M src/mainboard/portwell/m107/dsdt.asl
3 files changed, 0 insertions(+), 36 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/38134/6

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38134 )

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38134/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38134/4//COMMIT_MSG@16 
PS4, Line 16:
> Found-by: fwts {version}

Done

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38134 )

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
......................................................................

Patch Set 6: Code-Review+1

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38134 )

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38134 )

Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
......................................................................

{mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device

The mainboard ASL code contained a power button definition. This is not
required as the system uses the standard ACPI power button.

Remove the PWRB device from ASL.

BUG=N/A
TEST=build

Found-by: fwts 19.12.00
Change-Id: I4fac1411fd99475551bc970818759649f80b3f0e
Signed-off-by: Wim Vervoorn 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38134
Reviewed-by: Frans Hendriks 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/facebook/fbg1701/acpi/mainboard.asl
D src/mainboard/portwell/m107/acpi/mainboard.asl
M src/mainboard/portwell/m107/dsdt.asl
3 files changed, 0 insertions(+), 36 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Frans Hendriks: Looks good to me, approved

diff --git a/src/mainboard/facebook/fbg1701/acpi/mainboard.asl b/src/mainboard/facebook/fbg1701/acpi/mainboard.asl
index af79bd7..a7c9849 100644
--- a/src/mainboard/facebook/fbg1701/acpi/mainboard.asl
+++ b/src/mainboard/facebook/fbg1701/acpi/mainboard.asl
@@ -16,15 +16,6 @@
  * GNU General Public License for more details.
  */

-Scope (_SB)
-{
-	Device (PWRB)
-	{
-		Name (_HID, EisaId ("PNP0C0C"))
-		Name (_UID, 1)
-	}
-}
-
 /*
  * Onboard CPLD
  */
diff --git a/src/mainboard/portwell/m107/acpi/mainboard.asl b/src/mainboard/portwell/m107/acpi/mainboard.asl
deleted file mode 100644
index 2c325c6..0000000
--- a/src/mainboard/portwell/m107/acpi/mainboard.asl
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2012 Google Inc.
- * Copyright (C) 2015 Intel Corp.
- * Copyright (C) 2018 Eltan B.V.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-Scope (_SB)
-{
-	Device (PWRB)
-	{
-		Name (_HID, EisaId ("PNP0C0C"))
-		Name (_UID, 1)
-	}
-}
diff --git a/src/mainboard/portwell/m107/dsdt.asl b/src/mainboard/portwell/m107/dsdt.asl
index 6fcb39a..ced3e10 100644
--- a/src/mainboard/portwell/m107/dsdt.asl
+++ b/src/mainboard/portwell/m107/dsdt.asl
@@ -45,5 +45,4 @@

/* Mainboard specific sleep states */
    #include "acpi/sleepstates.asl"
-	#include "acpi/mainboard.asl"
 }