Attention is currently required from: Hung-Te Lin, Furquan Shaikh.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56789 )
Change subject: libpayload/pci: Split PCI interfaces as common and chip related
......................................................................
Patch Set 11:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56789/comment/f87d6a2b_a39a7c4f
PS2, Line 7: Split PCI interfaces as common and chip related
I haven't looked at the entire chain in detail yet, but I had provided some feedback on CB:53903 w. […]
Thanks for the suggestion, I add 'pci_map_bus()' for users to get the base address of config space in CL:56794.
Normally for embedded platform, the base address of PCIe hardware might be different, so I also provide a 'pci_update_hw_base()' function for users(e.g. depthcharge) to set its hardware base address, is that ok?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie74801bd4f3de51cbb574e86cd9bb09931152554
Gerrit-Change-Number: 56789
Gerrit-PatchSet: 11
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Comment-Date: Mon, 07 Mar 2022 11:22:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-MessageType: comment