Attention is currently required from: Nico Huber, Tarun Tuli, Martin L Roth, Jérémy Compostella, Angel Pons, Arthur Heymans, Kyösti Mälkki, Andrey Petrov.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 )
Change subject: [RFC] Pull libgfxinit in early romstage
......................................................................
Patch Set 4:
(3 comments)
File src/soc/intel/common/block/graphics/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164211):
https://review.coreboot.org/c/coreboot/+/69757/comment/782f3a18_2e7a195a
PS4, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) {
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164211):
https://review.coreboot.org/c/coreboot/+/69757/comment/7aa1b4d1_c3e1e283
PS4, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) {
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164211):
https://review.coreboot.org/c/coreboot/+/69757/comment/8d6d8595_6a891663
PS4, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) {
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69757
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718
Gerrit-Change-Number: 69757
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Tue, 22 Nov 2022 02:50:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment