[S] Change in libgfxinit[cros]: gma connectors: Add `Pipe' parameter to Pre_/Post_Off procedures

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/libgfxinit/+/82143?usp=email )

(

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: gma connectors: Add `Pipe' parameter to Pre_/Post_Off procedures
......................................................................

gma connectors: Add `Pipe' parameter to Pre_/Post_Off procedures

Change-Id: I01dbf3cae3dfef2130fa10116f70f23238c7a48c
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/82143
Reviewed-by: Kapil Porwal 
Reviewed-by: Angel Pons 
Tested-by: Dinesh Gehlot 
---
M common/g45/hw-gfx-gma-connectors.adb
M common/haswell_shared/hw-gfx-gma-connectors.adb
M common/hw-gfx-gma-connectors.ads
M common/hw-gfx-gma.adb
M common/ironlake/hw-gfx-gma-connectors.adb
M common/tigerlake/hw-gfx-gma-connectors.adb
6 files changed, 14 insertions(+), 14 deletions(-)

Approvals:
  Angel Pons: Looks good to me, approved
  Dinesh Gehlot: Verified
  Kapil Porwal: Looks good to me, approved

diff --git a/common/g45/hw-gfx-gma-connectors.adb b/common/g45/hw-gfx-gma-connectors.adb
index ff689bb..114fae3 100644
--- a/common/g45/hw-gfx-gma-connectors.adb
+++ b/common/g45/hw-gfx-gma-connectors.adb
@@ -69,7 +69,7 @@

----------------------------------------------------------------------------

-   procedure Pre_Off (Port_Cfg : Port_Config)
+   procedure Pre_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config)
    is
    begin
       pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity));
@@ -78,7 +78,7 @@
       Panel.Off (Port_Cfg.Panel);
    end Pre_Off;

-   procedure Post_Off (Port_Cfg : Port_Config)
+   procedure Post_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config)
    is
    begin
       pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity));
diff --git a/common/haswell_shared/hw-gfx-gma-connectors.adb b/common/haswell_shared/hw-gfx-gma-connectors.adb
index e81322e..b8a39ce 100644
--- a/common/haswell_shared/hw-gfx-gma-connectors.adb
+++ b/common/haswell_shared/hw-gfx-gma-connectors.adb
@@ -69,7 +69,7 @@

----------------------------------------------------------------------------

-   procedure Pre_Off (Port_Cfg : Port_Config)
+   procedure Pre_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config)
    is
    begin
       pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity));
@@ -78,7 +78,7 @@
       Panel.Off (Port_Cfg.Panel);
    end Pre_Off;

-   procedure Post_Off (Port_Cfg : Port_Config)
+   procedure Post_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config)
    is
    begin
       pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity));
diff --git a/common/hw-gfx-gma-connectors.ads b/common/hw-gfx-gma-connectors.ads
index a1d0d1e..d16f3a2 100644
--- a/common/hw-gfx-gma-connectors.ads
+++ b/common/hw-gfx-gma-connectors.ads
@@ -33,10 +33,10 @@
       Port_Cfg : in     Port_Config;
       PLL_Hint : in     Word32;
       Success  :    out Boolean);
-   pragma Warnings (GNATprove, On, "unused variable ""P*""");

-   procedure Pre_Off (Port_Cfg : Port_Config);
-   procedure Post_Off (Port_Cfg : Port_Config);
+   procedure Pre_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config);
+   procedure Post_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config);
+   pragma Warnings (GNATprove, On, "unused variable ""P*""");

procedure Pre_All_Off;
    procedure Post_All_Off;
diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb
index c3073d3..6331020 100644
--- a/common/hw-gfx-gma.adb
+++ b/common/hw-gfx-gma.adb
@@ -200,7 +200,7 @@

if not Success then
                      Display_Controller.Off (Pipe);
-                     Connectors.Post_Off (Port_Cfg);
+                     Connectors.Post_Off (Pipe, Port_Cfg);
                   end if;
                end if;

@@ -241,9 +241,9 @@
             Display_Controller.Legacy_VGA_Off;
          end if;

-         Connectors.Pre_Off (Port_Cfg);
+         Connectors.Pre_Off (Pipe, Port_Cfg);
          Display_Controller.Off (Pipe);
-         Connectors.Post_Off (Port_Cfg);
+         Connectors.Post_Off (Pipe, Port_Cfg);

PLLs.Free (Allocated_PLLs (Pipe));
       end if;
diff --git a/common/ironlake/hw-gfx-gma-connectors.adb b/common/ironlake/hw-gfx-gma-connectors.adb
index 1c3a243..bfe3047 100644
--- a/common/ironlake/hw-gfx-gma-connectors.adb
+++ b/common/ironlake/hw-gfx-gma-connectors.adb
@@ -104,7 +104,7 @@

----------------------------------------------------------------------------

-   procedure Pre_Off (Port_Cfg : Port_Config)
+   procedure Pre_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config)
    is
    begin
       pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity));
@@ -115,7 +115,7 @@
       end if;
    end Pre_Off;

-   procedure Post_Off (Port_Cfg : Port_Config)
+   procedure Post_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config)
    is
    begin
       pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity));
diff --git a/common/tigerlake/hw-gfx-gma-connectors.adb b/common/tigerlake/hw-gfx-gma-connectors.adb
index 5e66b96..73fafee 100644
--- a/common/tigerlake/hw-gfx-gma-connectors.adb
+++ b/common/tigerlake/hw-gfx-gma-connectors.adb
@@ -51,14 +51,14 @@
       Success := True;
    end Post_On;

-   procedure Pre_Off (Port_Cfg : Port_Config) is
+   procedure Pre_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config) is
    begin
       pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity));
       Panel.Backlight_Off (Port_Cfg.Panel);
       Panel.Off (Port_Cfg.Panel);
    end Pre_Off;

-   procedure Post_Off (Port_Cfg : Port_Config) is
+   procedure Post_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config) is
    begin
       pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity));
    end Post_Off;