Attention is currently required from: Jonathan Zhang, Tim Wawrzynczak. Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52734 )
Change subject: acpi: add SRAT Generic Initiator Affinity structure ......................................................................
Patch Set 3:
(2 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/52734/comment/b0819b59_ff9e2bdb PS3, Line 519: memcpy(gia->dev_handle, &seg, sizeof(seg)) memcpy(gia->dev_handle, &seg, 2)
https://review.coreboot.org/c/coreboot/+/52734/comment/7dd8b9ba_606b84dd PS3, Line 520: gia->dev_handle[2] = bus; /* Byte 2 has bus number */ : /* Byte 3 has bits 7:3 for dev, bits 2:0 for func */ : gia->dev_handle[3] = PCI_SLOT(dev) | PCI_FUNC(func); Create a seperated dev_handle_pci and dev_handle_acpi to make it easier to understand?