Attention is currently required from: Jonathan Zhang, Tim Wawrzynczak.
View Change
2 comments:
File src/acpi/acpi.c:
Patch Set #3, Line 519: memcpy(gia->dev_handle, &seg, sizeof(seg))
memcpy(gia->dev_handle, &seg, 2)
Patch Set #3, Line 520:
gia->dev_handle[2] = bus; /* Byte 2 has bus number */
/* Byte 3 has bits 7:3 for dev, bits 2:0 for func */
gia->dev_handle[3] = PCI_SLOT(dev) | PCI_FUNC(func);
Create a seperated dev_handle_pci and dev_handle_acpi to make it easier to understand?
To view, visit change 52734. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6ef01c59e02f30dc290f27e741027e16f5d8359
Gerrit-Change-Number: 52734
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Tue, 11 May 2021 10:33:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment