Attention is currently required from: Martin Roth, Hsuan-ting Chen. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60095 )
Change subject: coreboot-sdk/Dockerfile: Install libflashrom-dev ......................................................................
Patch Set 2:
(1 comment)
File util/docker/coreboot-sdk/Dockerfile:
https://review.coreboot.org/c/coreboot/+/60095/comment/52c4c94a_e28552be PS2, Line 124: CONFIG_EVERYTHING=yes make -C flashrom && \ I think this is building and using flashrom from source, so I think the proper solution will probably have to be to also make it build libflashrom from source here, rather than just try and pull in headers from some Ubuntu package that may be on a completely different version. I'm not quite sure how this works here though, it just seems to build flashrom but not install it. Hopefully Martin can help.
-
Julius Werner (Code Review)