Attention is currently required from: Subrata Banik, Sridhar Siricilla.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59668 )
Change subject: commonlib: Add new TS for CSE firmware Sync
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File src/commonlib/include/commonlib/timestamp_serialized.h:
https://review.coreboot.org/c/coreboot/+/59668/comment/86b38d1f_6b1bafb9
PS3, Line 141: TS_START_CSE_FW_SYNC = 972,
: TS_END_CSE_FW_SYNC = 973,
Hm, ideally these would go between 940 and 950 but there's only 1 space left.
However, TS_FIT_UCODE_LOADED appears unused in the tree currently, perhaps 948 could be repurposed?
File src/commonlib/include/commonlib/timestamp_serialized.h:
https://review.coreboot.org/c/coreboot/+/59668/comment/306944ba_41c80e3a
PS2, Line 210: cse_fw_sync
can you please explicitly call it "CSE firmware sync" ?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59668
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ed82c5358eb94b5e7c91b9fd783c5e09189b77a
Gerrit-Change-Number: 59668
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 15 Dec 2021 20:56:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment