Attention is currently required from: Michał Żygowski, Christian Walter, Krystian Hebel, Sergii Dmytruk.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68991 )
Change subject: security/tpm/: turn tis_{init,open} into tis_probe ......................................................................
Patch Set 1:
(2 comments)
File src/drivers/i2c/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/68991/comment/716e5f33_2514d535 PS1, Line 127: if (chip.is_open) { Does is_open really fulfill a purpose? The CRB implementation doesn't have that either.
I think we should just make tlcl_lib_init() the only entry point for all this, have the called-twice-check in there, say tis_probe() shouldn't get called from anywhere else, and then we can get rid of all the called-twice-checks in these individual implementations.
File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/68991/comment/c38a7b38_b3c44ee2 PS1, Line 188: uint32_t tlcl_lib_init(void) Since these functions are the same between 1.2 and 2.0 it would also be good to merge them into some file that's common between the two.