Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31058
Change subject: mb/google/sarien: Force power on after cr50 update ......................................................................
mb/google/sarien: Force power on after cr50 update
By default this board is configured to not power up after an EC reset. However in the case of a cr50 firmware update that will reset the EC it will end up powered off. In order to have it stay powered up configure the board to power up. This will get reset to the configured default when it boots again.
BUG=b:121380403 TEST=update cr50 firmware and reboot to ensure system boots and does not end up powered off.
Change-Id: I85beae24b1bc56bb0813f1fd1305218f04b0c1c8 Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/mainboard/google/sarien/chromeos.c 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/31058/1
diff --git a/src/mainboard/google/sarien/chromeos.c b/src/mainboard/google/sarien/chromeos.c index 0ea237a..f9e42e0 100644 --- a/src/mainboard/google/sarien/chromeos.c +++ b/src/mainboard/google/sarien/chromeos.c @@ -21,6 +21,10 @@ #include <variant/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include <security/tpm/tss.h> +#include <device/device.h> +#include <intelblocks/pmclib.h> +#include <soc/pmc.h> +#include <soc/pci_devs.h>
enum rec_mode_state { REC_MODE_UNINITIALIZED, @@ -111,3 +115,11 @@ { return 1; } + +void mainboard_cr50_update_reset(void) +{ +#if ENV_RAMSTAGE + /* Ensure system powers up after CR50 reset */ + pmc_set_afterg3(PCH_DEV_PMC, MAINBOARD_POWER_STATE_ON); +#endif +}
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31058 )
Change subject: mb/google/sarien: Force power on after cr50 update ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31058 )
Change subject: mb/google/sarien: Force power on after cr50 update ......................................................................
mb/google/sarien: Force power on after cr50 update
By default this board is configured to not power up after an EC reset. However in the case of a cr50 firmware update that will reset the EC it will end up powered off. In order to have it stay powered up configure the board to power up. This will get reset to the configured default when it boots again.
BUG=b:121380403 TEST=update cr50 firmware and reboot to ensure system boots and does not end up powered off.
Change-Id: I85beae24b1bc56bb0813f1fd1305218f04b0c1c8 Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/31058 Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/sarien/chromeos.c 1 file changed, 12 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved
diff --git a/src/mainboard/google/sarien/chromeos.c b/src/mainboard/google/sarien/chromeos.c index 0ea237a..f9e42e0 100644 --- a/src/mainboard/google/sarien/chromeos.c +++ b/src/mainboard/google/sarien/chromeos.c @@ -21,6 +21,10 @@ #include <variant/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include <security/tpm/tss.h> +#include <device/device.h> +#include <intelblocks/pmclib.h> +#include <soc/pmc.h> +#include <soc/pci_devs.h>
enum rec_mode_state { REC_MODE_UNINITIALIZED, @@ -111,3 +115,11 @@ { return 1; } + +void mainboard_cr50_update_reset(void) +{ +#if ENV_RAMSTAGE + /* Ensure system powers up after CR50 reset */ + pmc_set_afterg3(PCH_DEV_PMC, MAINBOARD_POWER_STATE_ON); +#endif +}
-
Duncan Laurie (Code Review) -
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)