Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36838 )
Change subject: soc/intel/common: Make alignment proper for comments ......................................................................
soc/intel/common: Make alignment proper for comments
Change-Id: If932582d03bb2f6d3d14c9bce45cf2030f3b3c4e Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/common/block/cpu/car/cache_as_ram.S M src/soc/intel/common/block/include/intelblocks/xhci.h M src/soc/intel/common/hda_verb.c 3 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/36838/1
diff --git a/src/soc/intel/common/block/cpu/car/cache_as_ram.S b/src/soc/intel/common/block/cpu/car/cache_as_ram.S index 471c18e..f66e91e 100644 --- a/src/soc/intel/common/block/cpu/car/cache_as_ram.S +++ b/src/soc/intel/common/block/cpu/car/cache_as_ram.S @@ -177,7 +177,7 @@ andl $0xfffffff0, %esp sub $8, %esp
- /*push TSC value to stack*/ + /* push TSC value to stack*/ movd %mm2, %eax pushl %eax /* tsc[63:32] */ movd %mm1, %eax diff --git a/src/soc/intel/common/block/include/intelblocks/xhci.h b/src/soc/intel/common/block/include/intelblocks/xhci.h index dd95bfb..0b3aa05 100644 --- a/src/soc/intel/common/block/include/intelblocks/xhci.h +++ b/src/soc/intel/common/block/include/intelblocks/xhci.h @@ -18,7 +18,7 @@
#include <device/device.h>
-/** +/* * struct xhci_usb_info - Data containing number of USB ports & offset. * @usb2_port_status_reg: Offset to USB2 port status register. * @num_usb2_ports: Number of USB2 ports. @@ -32,7 +32,7 @@ uint32_t num_usb3_ports; };
-/** +/* * pch_xhci_update_wake_event() - Identify and log XHCI wake events. * @info: Information about number of USB ports and their status reg offset. * @@ -46,7 +46,7 @@
void soc_xhci_init(struct device *dev);
-/** +/* * soc_get_xhci_usb_info() - Get the information about USB2 & USB3 ports. * * This function is used to get USB ports and status register offset information @@ -56,7 +56,7 @@ */ const struct xhci_usb_info *soc_get_xhci_usb_info(void);
-/** +/* * usb_xhci_disable_unused() - Disable unused USB devices * @ext_usb_xhci_en_cb: Callback function to be invoked, supplied by mainboard, * to identify the status of externally visible USB ports. diff --git a/src/soc/intel/common/hda_verb.c b/src/soc/intel/common/hda_verb.c index 3edad9b..03a23df 100644 --- a/src/soc/intel/common/hda_verb.c +++ b/src/soc/intel/common/hda_verb.c @@ -20,7 +20,7 @@ #include <delay.h> #include "hda_verb.h"
-/** +/* * Set bits in a register and wait for status */ static int set_bits(void *port, u32 mask, u32 val) @@ -52,7 +52,7 @@ return 0; }
-/** +/* * Probe for supported codecs */ int hda_codec_detect(u8 *base) @@ -95,7 +95,7 @@ return 0; }
-/** +/* * Wait 50usec for the codec to indicate it is ready * no response would imply that the codec is non-operative */ @@ -116,7 +116,7 @@ return -1; }
-/** +/* * Wait 50usec for the codec to indicate that it accepted * the previous command. No response would imply that the code * is non-operative @@ -145,7 +145,7 @@ return -1; }
-/** +/* * Find a specific entry within a verb table * * @param verb_table_bytes: verb table size in bytes @@ -190,7 +190,7 @@ return 0; }
-/** +/* * Write a supplied verb table */ int hda_codec_write(u8 *base, u32 size, const u32 *data) @@ -210,7 +210,7 @@ return 0; }
-/** +/* * Initialize codec, then find the verb table and write it */ int hda_codec_init(u8 *base, int addr, int verb_size, const u32 *verb_data)
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36838 )
Change subject: soc/intel/common: Make alignment proper for comments ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Thanks!
https://review.coreboot.org/c/coreboot/+/36838/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/36838/1/src/soc/intel/common/block/... PS1, Line 180: k*/ another space here?
Hello Patrick Rudolph, Angel Pons, Arthur Heymans, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36838
to look at the new patch set (#2).
Change subject: soc/intel/common: Make alignment proper for comments ......................................................................
soc/intel/common: Make alignment proper for comments
Change-Id: If932582d03bb2f6d3d14c9bce45cf2030f3b3c4e Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/common/block/cpu/car/cache_as_ram.S M src/soc/intel/common/block/include/intelblocks/xhci.h M src/soc/intel/common/hda_verb.c 3 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/36838/2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36838 )
Change subject: soc/intel/common: Make alignment proper for comments ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36838/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/36838/1/src/soc/intel/common/block/... PS1, Line 180: k*/
another space here?
Thanks a lot for pointer
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36838 )
Change subject: soc/intel/common: Make alignment proper for comments ......................................................................
Patch Set 2: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36838 )
Change subject: soc/intel/common: Make alignment proper for comments ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36838 )
Change subject: soc/intel/common: Make alignment proper for comments ......................................................................
soc/intel/common: Make alignment proper for comments
Change-Id: If932582d03bb2f6d3d14c9bce45cf2030f3b3c4e Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36838 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: V Sowmya v.sowmya@intel.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/soc/intel/common/block/cpu/car/cache_as_ram.S M src/soc/intel/common/block/include/intelblocks/xhci.h M src/soc/intel/common/hda_verb.c 3 files changed, 12 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved V Sowmya: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cpu/car/cache_as_ram.S b/src/soc/intel/common/block/cpu/car/cache_as_ram.S index 471c18e..0992d85 100644 --- a/src/soc/intel/common/block/cpu/car/cache_as_ram.S +++ b/src/soc/intel/common/block/cpu/car/cache_as_ram.S @@ -177,7 +177,7 @@ andl $0xfffffff0, %esp sub $8, %esp
- /*push TSC value to stack*/ + /* push TSC value to stack */ movd %mm2, %eax pushl %eax /* tsc[63:32] */ movd %mm1, %eax diff --git a/src/soc/intel/common/block/include/intelblocks/xhci.h b/src/soc/intel/common/block/include/intelblocks/xhci.h index dd95bfb..0b3aa05 100644 --- a/src/soc/intel/common/block/include/intelblocks/xhci.h +++ b/src/soc/intel/common/block/include/intelblocks/xhci.h @@ -18,7 +18,7 @@
#include <device/device.h>
-/** +/* * struct xhci_usb_info - Data containing number of USB ports & offset. * @usb2_port_status_reg: Offset to USB2 port status register. * @num_usb2_ports: Number of USB2 ports. @@ -32,7 +32,7 @@ uint32_t num_usb3_ports; };
-/** +/* * pch_xhci_update_wake_event() - Identify and log XHCI wake events. * @info: Information about number of USB ports and their status reg offset. * @@ -46,7 +46,7 @@
void soc_xhci_init(struct device *dev);
-/** +/* * soc_get_xhci_usb_info() - Get the information about USB2 & USB3 ports. * * This function is used to get USB ports and status register offset information @@ -56,7 +56,7 @@ */ const struct xhci_usb_info *soc_get_xhci_usb_info(void);
-/** +/* * usb_xhci_disable_unused() - Disable unused USB devices * @ext_usb_xhci_en_cb: Callback function to be invoked, supplied by mainboard, * to identify the status of externally visible USB ports. diff --git a/src/soc/intel/common/hda_verb.c b/src/soc/intel/common/hda_verb.c index 3edad9b..03a23df 100644 --- a/src/soc/intel/common/hda_verb.c +++ b/src/soc/intel/common/hda_verb.c @@ -20,7 +20,7 @@ #include <delay.h> #include "hda_verb.h"
-/** +/* * Set bits in a register and wait for status */ static int set_bits(void *port, u32 mask, u32 val) @@ -52,7 +52,7 @@ return 0; }
-/** +/* * Probe for supported codecs */ int hda_codec_detect(u8 *base) @@ -95,7 +95,7 @@ return 0; }
-/** +/* * Wait 50usec for the codec to indicate it is ready * no response would imply that the codec is non-operative */ @@ -116,7 +116,7 @@ return -1; }
-/** +/* * Wait 50usec for the codec to indicate that it accepted * the previous command. No response would imply that the code * is non-operative @@ -145,7 +145,7 @@ return -1; }
-/** +/* * Find a specific entry within a verb table * * @param verb_table_bytes: verb table size in bytes @@ -190,7 +190,7 @@ return 0; }
-/** +/* * Write a supplied verb table */ int hda_codec_write(u8 *base, u32 size, const u32 *data) @@ -210,7 +210,7 @@ return 0; }
-/** +/* * Initialize codec, then find the verb table and write it */ int hda_codec_init(u8 *base, int addr, int verb_size, const u32 *verb_data)
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Subrata Banik (Code Review)
-
V Sowmya (Code Review)