Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29565 )
Change subject: lenovo/h8,thinkpads: Re-do USB Always On ......................................................................
Patch Set 5:
(4 comments)
Addressed all proposals above and rebased on top of current master.
https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c File src/ec/lenovo/h8/h8.c:
https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c@136 PS4, Line 136: e UA
Pointless comment. […]
Done
https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c@138 PS4, Line 138: val &= ~(H8_USB_ALWAYS_ON_ENABLE | H8_USB_ALWAYS_ON_AC_ONLY); // Clear bits 0,2,3
space required before the open brace '{'
Done
https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c@138 PS4, Line 138: val &= ~(H8_USB_ALWAYS_ON_ENABLE | H8_USB_ALWAYS_ON_AC_ONLY); // Clear bits 0,2,3
space required before the open parenthesis '('
Done
https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c@141 PS4, Line 141:
Please don't use magic values
Done