Attention is currently required from: Ravi kumar, Ravi Kumar Bokka, Sudheer Amrabadi. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56642 )
Change subject: google/herobrine: configure gpio to detect board ID. ......................................................................
Patch Set 37: Code-Review+2
(13 comments)
Patchset:
PS37: Hi Ravi, please resolve the fixes that you made after you fix them. It makes it easier for the reviewer to see what you did between patches. Thanks!
File src/mainboard/google/herobrine/boardid.c:
https://review.coreboot.org/c/coreboot/+/56642/comment/1b98d37d_f7f09699 PS36, Line 14: if (CONFIG(BOARD_GOOGLE_HEROBRINE)){
space required before the open brace '{' […]
Done
https://review.coreboot.org/c/coreboot/+/56642/comment/66347079_438a1015 PS36, Line 19: else if (CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN) || CONFIG(BOARD_GOOGLE_SENOR)){
else should follow close brace '}' […]
Done
https://review.coreboot.org/c/coreboot/+/56642/comment/207459a5_39bf1ae3 PS36, Line 19: else if (CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN) || CONFIG(BOARD_GOOGLE_SENOR)){
line over 96 characters […]
Done
https://review.coreboot.org/c/coreboot/+/56642/comment/1feaf90f_0678af9e PS36, Line 19: else if (CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN) || CONFIG(BOARD_GOOGLE_SENOR)){
space required before the open brace '{' […]
Done
https://review.coreboot.org/c/coreboot/+/56642/comment/20e9ec54_82c5a0fd PS36, Line 20: pins[2] = GPIO(50);
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/56642/comment/efbea88e_0f95edc4 PS36, Line 20: pins[2] = GPIO(50);
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/56642/comment/1169f3bb_cf5c3368 PS36, Line 21: pins[1] = GPIO(49);
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/56642/comment/3cdcd765_5d2d5d8d PS36, Line 21: pins[1] = GPIO(49);
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/56642/comment/bd6cb616_53eefe03 PS36, Line 22: pins[0] = GPIO(48);
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/56642/comment/2e853318_54878b98 PS36, Line 22: pins[0] = GPIO(48);
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/56642/comment/9d47bc4e_db659eba PS36, Line 26: if (id == UNDEFINED_STRAPPING_ID){
braces {} are not necessary for single statement blocks […]
Done
https://review.coreboot.org/c/coreboot/+/56642/comment/905837d0_6e1030ce PS36, Line 26: if (id == UNDEFINED_STRAPPING_ID){
space required before the open brace '{' […]
Done
-
Shelley Chen (Code Review)