Change in ...coreboot[master]: soc/{qualcomm,rockchip}: Use 'include <stdlib.h>' when appropriate
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33691
Change subject: soc/{qualcomm,rockchip}: Use 'include <stdlib.h>' when appropriate ......................................................................
soc/{qualcomm,rockchip}: Use 'include <stdlib.h>' when appropriate
Change-Id: Iab605f6be4a48c10fa5aae7a1222520149ad1392 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/qualcomm/ipq806x/spi.c M src/soc/rockchip/common/edp.c M src/soc/rockchip/common/spi.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/33691/1
diff --git a/src/soc/qualcomm/ipq806x/spi.c b/src/soc/qualcomm/ipq806x/spi.c index 2657b9c..65ce594 100644 --- a/src/soc/qualcomm/ipq806x/spi.c +++ b/src/soc/qualcomm/ipq806x/spi.c @@ -19,7 +19,7 @@ #include <gpio.h> #include <soc/iomap.h> #include <soc/spi.h> -#include <stdlib.h> +#include <stddef.h>
#define SUCCESS 0
diff --git a/src/soc/rockchip/common/edp.c b/src/soc/rockchip/common/edp.c index 91e2de9..301bc41 100644 --- a/src/soc/rockchip/common/edp.c +++ b/src/soc/rockchip/common/edp.c @@ -18,7 +18,7 @@ #include <delay.h> #include <device/device.h> #include <edid.h> -#include <stdlib.h> +#include <stddef.h> #include <stdint.h> #include <string.h> #include <soc/addressmap.h> diff --git a/src/soc/rockchip/common/spi.c b/src/soc/rockchip/common/spi.c index e929419..1fc5889 100644 --- a/src/soc/rockchip/common/spi.c +++ b/src/soc/rockchip/common/spi.c @@ -23,7 +23,7 @@ #include <soc/clock.h> #include <spi-generic.h> #include <spi_flash.h> -#include <stdlib.h> +#include <stddef.h> #include <timer.h>
struct rockchip_spi_slave {
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33691
to look at the new patch set (#4).
Change subject: soc/{qualcomm,rockchip}: Use 'include <stdlib.h>' when appropriate ......................................................................
soc/{qualcomm,rockchip}: Use 'include <stdlib.h>' when appropriate
Also including <types.h>, is supposed to provide stdint and stddef.
Change-Id: Iab605f6be4a48c10fa5aae7a1222520149ad1392 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/qualcomm/ipq806x/spi.c M src/soc/rockchip/common/edp.c M src/soc/rockchip/common/spi.c 3 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/33691/4
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33691 )
Change subject: soc/{qualcomm,rockchip}: Use 'include <stdlib.h>' when appropriate ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33691 )
Change subject: soc/{qualcomm,rockchip}: Use 'include <stdlib.h>' when appropriate ......................................................................
soc/{qualcomm,rockchip}: Use 'include <stdlib.h>' when appropriate
Also including <types.h>, is supposed to provide stdint and stddef.
Change-Id: Iab605f6be4a48c10fa5aae7a1222520149ad1392 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33691 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/soc/qualcomm/ipq806x/spi.c M src/soc/rockchip/common/edp.c M src/soc/rockchip/common/spi.c 3 files changed, 3 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/soc/qualcomm/ipq806x/spi.c b/src/soc/qualcomm/ipq806x/spi.c index 2657b9c..64a98d5 100644 --- a/src/soc/qualcomm/ipq806x/spi.c +++ b/src/soc/qualcomm/ipq806x/spi.c @@ -19,7 +19,7 @@ #include <gpio.h> #include <soc/iomap.h> #include <soc/spi.h> -#include <stdlib.h> +#include <types.h>
#define SUCCESS 0
diff --git a/src/soc/rockchip/common/edp.c b/src/soc/rockchip/common/edp.c index 91e2de9..ea0930a 100644 --- a/src/soc/rockchip/common/edp.c +++ b/src/soc/rockchip/common/edp.c @@ -18,13 +18,12 @@ #include <delay.h> #include <device/device.h> #include <edid.h> -#include <stdlib.h> -#include <stdint.h> #include <string.h> #include <soc/addressmap.h> #include <soc/display.h> #include <soc/edp.h> #include <timer.h> +#include <types.h>
#define edp_debug(x...) do {if (0) printk(BIOS_DEBUG, x); } while (0)
diff --git a/src/soc/rockchip/common/spi.c b/src/soc/rockchip/common/spi.c index e929419..7bde433 100644 --- a/src/soc/rockchip/common/spi.c +++ b/src/soc/rockchip/common/spi.c @@ -23,8 +23,8 @@ #include <soc/clock.h> #include <spi-generic.h> #include <spi_flash.h> -#include <stdlib.h> #include <timer.h> +#include <types.h>
struct rockchip_spi_slave { struct rockchip_spi *regs;
-
HAOUAS Elyes (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)