Change in coreboot[master]: biostar/a68n-5200: Add Fan control via IMC option

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Damien Zammit (Code Review)

19 Jan 2020 19 Jan '20

1:52 a.m.

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38467 )

Change subject: biostar/a68n-5200: Add Fan control via IMC option ......................................................................

biostar/a68n-5200: Add Fan control via IMC option

NB: Fan still does not work on this board even with this option enabled.

WORKAROUND: Plug the cpu fan into the SYSFAN port. It will be always on at max rpm, but at least won't overheat.

Change-Id: Idcefe5170913f192e67518f4a6d90b0ac71ae176 Signed-off-by: Damien Zammit damien@zamaudio.com --- M src/mainboard/biostar/a68n_5200/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/38467/1

diff --git a/src/mainboard/biostar/a68n_5200/Kconfig b/src/mainboard/biostar/a68n_5200/Kconfig index f608513..714900c 100644 --- a/src/mainboard/biostar/a68n_5200/Kconfig +++ b/src/mainboard/biostar/a68n_5200/Kconfig @@ -33,6 +33,7 @@ select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_4096 select GFXUMA + select HUDSON_IMC_ENABLE

config MAINBOARD_DIR string

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

HAOUAS Elyes (Code Review)

19 Jan 19 Jan

6:51 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38467 )

Change subject: biostar/a68n-5200: Add Fan control via IMC option ......................................................................

Patch Set 1:

would you try to (enable and then) disable SuperIO at 0x4e (and keep only 0x2e enabled)? (I mean, maybe the SupetIO is by default enabling 0x4e)

-- To view, visit https://review.coreboot.org/c/coreboot/+/38467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcefe5170913f192e67518f4a6d90b0ac71ae176 Gerrit-Change-Number: 38467 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Sun, 19 Jan 2020 06:51:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:22 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38467 )

Change subject: biostar/a68n-5200: Add Fan control via IMC option ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcefe5170913f192e67518f4a6d90b0ac71ae176 Gerrit-Change-Number: 38467 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 19 Jan 2020 10:22:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

11:20 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38467 )

Change subject: biostar/a68n-5200: Add Fan control via IMC option ......................................................................

Patch Set 1:

If it doesn’t work with this option, please mark this change-set as WIP (option in Gerrit on the right ... menu).

-- To view, visit https://review.coreboot.org/c/coreboot/+/38467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcefe5170913f192e67518f4a6d90b0ac71ae176 Gerrit-Change-Number: 38467 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 19 Jan 2020 11:20:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

2:11 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38467 )

Change subject: biostar/a68n-5200: Add Fan control via IMC option ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38467/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38467/1//COMMIT_MSG@9 PS1, Line 9: NB: Fan still does not work on this board even with this option enabled. So what's the effect of this change?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcefe5170913f192e67518f4a6d90b0ac71ae176 Gerrit-Change-Number: 38467 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 19 Jan 2020 14:11:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Damien Zammit (Code Review)

20 Jan 20 Jan

9:25 a.m.

Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38467 )

Change subject: biostar/a68n-5200: Add Fan control via IMC option ......................................................................

Patch Set 1:

(1 comment)

Fan is still not spinning at all.

https://review.coreboot.org/c/coreboot/+/38467/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38467/1//COMMIT_MSG@9 PS1, Line 9: NB: Fan still does not work on this board even with this option enabled.

...

So what's the effect of this change?

This change adds a selectable option of IMC firmware in Kconfig and when turned on, it enables the code path that is supposed to make the fan work, albeit does not seem to have any noticeable effect with the option turned on or off, ie the fan is still not spinning in either mode.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcefe5170913f192e67518f4a6d90b0ac71ae176 Gerrit-Change-Number: 38467 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 20 Jan 2020 09:25:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Felix Held (Code Review)

3:03 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38467 )

Change subject: biostar/a68n-5200: Add Fan control via IMC option ......................................................................

Patch Set 1:

i highly doubt that this will fix the issue. my guess is that the board uses the sio for fan control; i only know about 1 board using the imc for fan control. the it8728f seems to have fan control support in its driver; it needs some devicetree entries. have a look at devicetree_f2a85-m.cb to see how to use that

-- To view, visit https://review.coreboot.org/c/coreboot/+/38467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcefe5170913f192e67518f4a6d90b0ac71ae176 Gerrit-Change-Number: 38467 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 20 Jan 2020 15:03:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1715

days inactive

1716

days old

coreboot-gerrit@coreboot.org

6 comments

5 participants

tags (0)

participants (5)

Damien Zammit (Code Review)
Felix Held (Code Review)
HAOUAS Elyes (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)