Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46088 )
Change subject: soc/intel: Make use of common gfx.asl ......................................................................
soc/intel: Make use of common gfx.asl
Add gfx.asl file for all IA SOCs to allow for graphics-related ACPI devices and methods.
TEST=Able to build and boot TGL platform Dump and disassemble DSDT, verify GFX0 device present as below
Device (GFX0) { Name (_ADR, 0x00020000) // _ADR: Address }
Change-Id: I5560e900a77872552df1064dc3b7a8148e35d682 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/alderlake/acpi/southbridge.asl M src/soc/intel/apollolake/acpi/southbridge.asl M src/soc/intel/elkhartlake/acpi/southbridge.asl M src/soc/intel/icelake/acpi/southbridge.asl M src/soc/intel/jasperlake/acpi/southbridge.asl M src/soc/intel/tigerlake/acpi/southbridge.asl 6 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/46088/1
diff --git a/src/soc/intel/alderlake/acpi/southbridge.asl b/src/soc/intel/alderlake/acpi/southbridge.asl index 373dca5..42f3b12 100644 --- a/src/soc/intel/alderlake/acpi/southbridge.asl +++ b/src/soc/intel/alderlake/acpi/southbridge.asl @@ -17,6 +17,9 @@ /* GPIO controller */ #include "gpio.asl"
+/* GFX 00:02.0 */ +#include <soc/intel/common/block/acpi/acpi/gfx.asl> + /* ESPI 0:1f.0 */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
diff --git a/src/soc/intel/apollolake/acpi/southbridge.asl b/src/soc/intel/apollolake/acpi/southbridge.asl index f4d1497..4a8be47 100644 --- a/src/soc/intel/apollolake/acpi/southbridge.asl +++ b/src/soc/intel/apollolake/acpi/southbridge.asl @@ -17,6 +17,9 @@
#include "xhci.asl"
+/* GFX 00:02.0 */ +#include <soc/intel/common/block/acpi/acpi/gfx.asl> + /* LPC */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
diff --git a/src/soc/intel/elkhartlake/acpi/southbridge.asl b/src/soc/intel/elkhartlake/acpi/southbridge.asl index d85ddac..28705b1 100644 --- a/src/soc/intel/elkhartlake/acpi/southbridge.asl +++ b/src/soc/intel/elkhartlake/acpi/southbridge.asl @@ -14,6 +14,9 @@ /* GPIO controller */ #include "gpio.asl"
+/* GFX 00:02.0 */ +#include <soc/intel/common/block/acpi/acpi/gfx.asl> + /* ESPI 0:1f.0 */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
diff --git a/src/soc/intel/icelake/acpi/southbridge.asl b/src/soc/intel/icelake/acpi/southbridge.asl index 4abea7c..129a88d 100644 --- a/src/soc/intel/icelake/acpi/southbridge.asl +++ b/src/soc/intel/icelake/acpi/southbridge.asl @@ -17,6 +17,9 @@ /* GPIO controller */ #include "gpio.asl"
+/* GFX 00:02.0 */ +#include <soc/intel/common/block/acpi/acpi/gfx.asl> + /* ESPI 0:1f.0 */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
diff --git a/src/soc/intel/jasperlake/acpi/southbridge.asl b/src/soc/intel/jasperlake/acpi/southbridge.asl index b68539a..b82cce5 100644 --- a/src/soc/intel/jasperlake/acpi/southbridge.asl +++ b/src/soc/intel/jasperlake/acpi/southbridge.asl @@ -17,6 +17,9 @@ /* GPIO controller */ #include "gpio.asl"
+/* GFX 00:02.0 */ +#include <soc/intel/common/block/acpi/acpi/gfx.asl> + /* ESPI 0:1f.0 */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
diff --git a/src/soc/intel/tigerlake/acpi/southbridge.asl b/src/soc/intel/tigerlake/acpi/southbridge.asl index 373dca5..42f3b12 100644 --- a/src/soc/intel/tigerlake/acpi/southbridge.asl +++ b/src/soc/intel/tigerlake/acpi/southbridge.asl @@ -17,6 +17,9 @@ /* GPIO controller */ #include "gpio.asl"
+/* GFX 00:02.0 */ +#include <soc/intel/common/block/acpi/acpi/gfx.asl> + /* ESPI 0:1f.0 */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46088 )
Change subject: soc/intel: Make use of common gfx.asl ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46088 )
Change subject: soc/intel: Make use of common gfx.asl ......................................................................
Patch Set 1: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46088 )
Change subject: soc/intel: Make use of common gfx.asl ......................................................................
soc/intel: Make use of common gfx.asl
Add gfx.asl file for all IA SOCs to allow for graphics-related ACPI devices and methods.
TEST=Able to build and boot TGL platform Dump and disassemble DSDT, verify GFX0 device present as below
Device (GFX0) { Name (_ADR, 0x00020000) // _ADR: Address }
Change-Id: I5560e900a77872552df1064dc3b7a8148e35d682 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46088 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/alderlake/acpi/southbridge.asl M src/soc/intel/apollolake/acpi/southbridge.asl M src/soc/intel/elkhartlake/acpi/southbridge.asl M src/soc/intel/icelake/acpi/southbridge.asl M src/soc/intel/jasperlake/acpi/southbridge.asl M src/soc/intel/tigerlake/acpi/southbridge.asl 6 files changed, 18 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/alderlake/acpi/southbridge.asl b/src/soc/intel/alderlake/acpi/southbridge.asl index 373dca5..42f3b12 100644 --- a/src/soc/intel/alderlake/acpi/southbridge.asl +++ b/src/soc/intel/alderlake/acpi/southbridge.asl @@ -17,6 +17,9 @@ /* GPIO controller */ #include "gpio.asl"
+/* GFX 00:02.0 */ +#include <soc/intel/common/block/acpi/acpi/gfx.asl> + /* ESPI 0:1f.0 */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
diff --git a/src/soc/intel/apollolake/acpi/southbridge.asl b/src/soc/intel/apollolake/acpi/southbridge.asl index f4d1497..4a8be47 100644 --- a/src/soc/intel/apollolake/acpi/southbridge.asl +++ b/src/soc/intel/apollolake/acpi/southbridge.asl @@ -17,6 +17,9 @@
#include "xhci.asl"
+/* GFX 00:02.0 */ +#include <soc/intel/common/block/acpi/acpi/gfx.asl> + /* LPC */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
diff --git a/src/soc/intel/elkhartlake/acpi/southbridge.asl b/src/soc/intel/elkhartlake/acpi/southbridge.asl index d85ddac..28705b1 100644 --- a/src/soc/intel/elkhartlake/acpi/southbridge.asl +++ b/src/soc/intel/elkhartlake/acpi/southbridge.asl @@ -14,6 +14,9 @@ /* GPIO controller */ #include "gpio.asl"
+/* GFX 00:02.0 */ +#include <soc/intel/common/block/acpi/acpi/gfx.asl> + /* ESPI 0:1f.0 */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
diff --git a/src/soc/intel/icelake/acpi/southbridge.asl b/src/soc/intel/icelake/acpi/southbridge.asl index 4abea7c..129a88d 100644 --- a/src/soc/intel/icelake/acpi/southbridge.asl +++ b/src/soc/intel/icelake/acpi/southbridge.asl @@ -17,6 +17,9 @@ /* GPIO controller */ #include "gpio.asl"
+/* GFX 00:02.0 */ +#include <soc/intel/common/block/acpi/acpi/gfx.asl> + /* ESPI 0:1f.0 */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
diff --git a/src/soc/intel/jasperlake/acpi/southbridge.asl b/src/soc/intel/jasperlake/acpi/southbridge.asl index b68539a..b82cce5 100644 --- a/src/soc/intel/jasperlake/acpi/southbridge.asl +++ b/src/soc/intel/jasperlake/acpi/southbridge.asl @@ -17,6 +17,9 @@ /* GPIO controller */ #include "gpio.asl"
+/* GFX 00:02.0 */ +#include <soc/intel/common/block/acpi/acpi/gfx.asl> + /* ESPI 0:1f.0 */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
diff --git a/src/soc/intel/tigerlake/acpi/southbridge.asl b/src/soc/intel/tigerlake/acpi/southbridge.asl index 373dca5..42f3b12 100644 --- a/src/soc/intel/tigerlake/acpi/southbridge.asl +++ b/src/soc/intel/tigerlake/acpi/southbridge.asl @@ -17,6 +17,9 @@ /* GPIO controller */ #include "gpio.asl"
+/* GFX 00:02.0 */ +#include <soc/intel/common/block/acpi/acpi/gfx.asl> + /* ESPI 0:1f.0 */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
-
Angel Pons (Code Review) -
Duncan Laurie (Code Review)
-
Subrata Banik (Code Review)