Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Matt DeVillier.
Felix Held has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/77682?usp=email )
Change subject: soc/amd/cezanne: Add ACPI opregion to root complex
......................................................................
Patch Set 5:
(1 comment)
File src/soc/amd/cezanne/root_complex.c:
https://review.coreboot.org/c/coreboot/+/77682/comment/53a5261c_eeedf17e?usp... :
PS1, Line 195: 0x60
so is this access done on system startup/reboot/resume or when audio playback is started? if it's th […]
with the comment i'm ok with this; mainly due to not having a significantly better solution for the problem. if we find a better solution, this should eventually be reworked
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77682?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4d00c86647e51e5cae621fe788f0a1b06471a443
Gerrit-Change-Number: 77682
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Mon, 24 Feb 2025 12:54:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de