Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Michael Niewöhner, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57366 )
Change subject: SMBIOS: Allow skipping default SMBIOS generation ......................................................................
Patch Set 1:
(2 comments)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/57366/comment/0896562f_4f0a64d7 PS1, Line 1223: } else { Not quite. I think we should turn the `dev->enabled` check into a separate
if (!dev->enabled) continue;
Maybe as a separate commit ahead. I just noticed that the current doesn't check that for the two functions below. That looks like a bug, though.
https://review.coreboot.org/c/coreboot/+/57366/comment/162fc1b2_704a513b PS1, Line 1225: len += smbios_generate_type41_from_devtree(dev, handle, current); Instead of exposing these as API, we'd usually have a default get_smbios_data() that is called instead of the .ops one. So anyone who wants to write a .get_smbios_data() whilst keeping the default code, would also just have to call that single default function.