Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Michael Niewöhner, Patrick Rudolph.
2 comments:
File src/arch/x86/smbios.c:
Patch Set #1, Line 1223: } else {
Not quite. I think we should turn the `dev->enabled` check into a separate
if (!dev->enabled)
continue;
Maybe as a separate commit ahead. I just noticed that the current doesn't
check that for the two functions below. That looks like a bug, though.
Patch Set #1, Line 1225: len += smbios_generate_type41_from_devtree(dev, handle, current);
Instead of exposing these as API, we'd usually have a default get_smbios_data() that
is called instead of the .ops one. So anyone who wants to write a .get_smbios_data()
whilst keeping the default code, would also just have to call that single default
function.
To view, visit change 57366. To unsubscribe, or for help writing mail filters, visit settings.