Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69410 )
Change subject: soc/amd/*: Enable override of MAINBOARD_BLOBS_DIR
......................................................................
Patch Set 2:
(2 comments)
File src/soc/amd/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/69410/comment/13f02603_c12829bc
PS2, Line 19:
Nit: get rid of 2nd blank line.
File src/soc/amd/common/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/69410/comment/a1127deb_9e14b48b
PS2, Line 49: $(patsubst
There's a macro for this already.
$(call strip_quotes,$(CONFIG_APCB_BLOBS_DIR))
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69410
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0702fdb97fbc2c73d97994ab4d5161ff0f467518
Gerrit-Change-Number: 69410
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 30 Nov 2022 20:20:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment