Change in coreboot[master]: mb/google/mancomb: Enable AMD I2S Machine Driver - coreboot-gerrit

20 May 2021


      Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54549 )
Change subject: mb/google/mancomb: Enable AMD I2S Machine Driver
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/mancomb/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/54549/comment/47fe5ae1_5a772de1 
PS3, Line 126: AMDI5682
...
Should it be 10025682?
That is just same as guybrush.
https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/b1768df2...
Checked the b/184617007#62 , it seems AMDI5682 is fine.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/54549
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I528f90d81a418236e512a1e0840ff44c3a3a983e
Gerrit-Change-Number: 54549
Gerrit-PatchSet: 3
Gerrit-Owner: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-CC: Yu-hsuan Hsu yuhsuan@google.com
Gerrit-Comment-Date: Thu, 20 May 2021 10:59:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-hsuan Hsu yuhsuan@google.com
Gerrit-MessageType: comment