Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36387 )
Change subject: commonlib/helpers: Add alloca() macro ......................................................................
commonlib/helpers: Add alloca() macro
If there is no alloca() macro defined, then define it as __builtin_alloca(), as most compilers support that as an intrinsic instead, if no alloca.h is included.
Change-Id: I8730d57ce7c2f323b52e7a5720c598fb7af16b44 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/helpers.h 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/36387/1
diff --git a/src/commonlib/include/commonlib/helpers.h b/src/commonlib/include/commonlib/helpers.h index 4429ea4..f3b71d7 100644 --- a/src/commonlib/include/commonlib/helpers.h +++ b/src/commonlib/include/commonlib/helpers.h @@ -137,4 +137,8 @@ #define __unused __attribute__((unused)) #endif
+#ifndef alloca +#define alloca(x) __builtin_alloca(x) +#endif + #endif /* COMMONLIB_HELPERS_H */
Hello Karthik Ramasubramanian, Julius Werner, build bot (Jenkins), Joel Kitching, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36387
to look at the new patch set (#3).
Change subject: commonlib/helpers: Add alloca() macro ......................................................................
commonlib/helpers: Add alloca() macro
If there is no alloca() macro defined, then define it as __builtin_alloca(), as most compilers support that as an intrinsic instead, if no alloca.h is included.
Change-Id: I8730d57ce7c2f323b52e7a5720c598fb7af16b44 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/commonlib/include/commonlib/helpers.h 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/36387/3
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36387 )
Change subject: commonlib/helpers: Add alloca() macro ......................................................................
Patch Set 3: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36387 )
Change subject: commonlib/helpers: Add alloca() macro ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36387 )
Change subject: commonlib/helpers: Add alloca() macro ......................................................................
commonlib/helpers: Add alloca() macro
If there is no alloca() macro defined, then define it as __builtin_alloca(), as most compilers support that as an intrinsic instead, if no alloca.h is included.
Change-Id: I8730d57ce7c2f323b52e7a5720c598fb7af16b44 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/36387 Reviewed-by: Julius Werner jwerner@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/commonlib/include/commonlib/helpers.h 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Julius Werner: Looks good to me, approved
diff --git a/src/commonlib/include/commonlib/helpers.h b/src/commonlib/include/commonlib/helpers.h index 4429ea4..f3b71d7 100644 --- a/src/commonlib/include/commonlib/helpers.h +++ b/src/commonlib/include/commonlib/helpers.h @@ -137,4 +137,8 @@ #define __unused __attribute__((unused)) #endif
+#ifndef alloca +#define alloca(x) __builtin_alloca(x) +#endif + #endif /* COMMONLIB_HELPERS_H */
-
Furquan Shaikh (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)