Attention is currently required from: Hung-Te Lin, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85888?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8196: Initialize MCUPM ......................................................................
Patch Set 4:
(5 comments)
File src/soc/mediatek/mt8196/include/soc/mcupm_plat.h:
https://review.coreboot.org/c/coreboot/+/85888/comment/1e9ec5a9_fe5a3909?usp... : PS4, Line 38: /* 0x1C004000 */ Remove comment
https://review.coreboot.org/c/coreboot/+/85888/comment/85c3e34c_0643c942?usp... : PS4, Line 40: b B
https://review.coreboot.org/c/coreboot/+/85888/comment/13d4c6ac_13b05231?usp... : PS4, Line 82: 0x00000004 0x4
https://review.coreboot.org/c/coreboot/+/85888/comment/42c2b840_4bef1f74?usp... : PS4, Line 84: 0x00000014 0x14
File src/soc/mediatek/mt8196/mcupm.c:
https://review.coreboot.org/c/coreboot/+/85888/comment/13d54808_3df06734?usp... : PS4, Line 40: "[EB_SPMC] Polling ACK timeout, %#x\n", move to previous line