Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86352?usp=email )
Change subject: soc/mediatek/mt8196: Add validity check for PI_IMG ......................................................................
soc/mediatek/mt8196: Add validity check for PI_IMG
Add a simple validity check for the PI_IMG firmware file.
BUG=none TEST=emerge-rauru coreboot BRANCH=rauru
Change-Id: I7b8085c1229c1a7a8cad904e166471ff8bda5cfb Signed-off-by: Yu-Ping Wu yupingso@chromium.org --- M src/soc/mediatek/mt8196/Makefile.mk 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/86352/1
diff --git a/src/soc/mediatek/mt8196/Makefile.mk b/src/soc/mediatek/mt8196/Makefile.mk index 4dd2d2d..a67da6b 100644 --- a/src/soc/mediatek/mt8196/Makefile.mk +++ b/src/soc/mediatek/mt8196/Makefile.mk @@ -115,6 +115,13 @@ $(if $(wildcard $($(fw)-file)), $(eval cbfs-files-y += $(fw)), ) \ )
+# Validity check for PI_IMG. +PI_IMG_COOKIE_COUNT := $(shell xxd -p -c 4 --seek 0x200 $(MT8196_BLOB_DIR)/$(CONFIG_PI_IMG_FIRMWARE) \ + | grep -c b4a6c317) +ifneq ($(PI_IMG_COOKIE_COUNT),2) +$(error Invalid PI_IMG $(CONFIG_PI_IMG_FIRMWARE)) +endif + DRAM_CBFS := $(CONFIG_CBFS_PREFIX)/dram $(DRAM_CBFS)-file := $(MT8196_BLOB_DIR)/dram.elf $(DRAM_CBFS)-type := stage