Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Sridhar Siricilla, Michael Niewöhner.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59358 )
Change subject: src/include/acpi: Move CPPC_PACKAGE_NAME macro definition
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59358/comment/786e5c9a_cd220e43
PS1, Line 9: The patch move CPPC_PACKAGE_NAME macro definition from acpi/acpigen.c
: to include/acpi/acpigen.h.
commit messages should say why you do things, not just what you do.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59358
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic547445cdbe2b1a3efe44390bd127f577386e7fc
Gerrit-Change-Number: 59358
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Thu, 18 Nov 2021 08:14:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment