Change in coreboot[master]: src/sb/intel/common/pirq_gen: Rework generating pin-route tables
Nico Huber has posted comments on this change. ( https://review.coreboot.org/22979 )
Change subject: src/sb/intel/common/pirq_gen: Rework generating pin-route tables ......................................................................
Patch Set 5:
(3 comments)
Looks much better this way :)
Would it cause any trouble to include rcba_pirq.h from bd82x6x/pch.h? It would safe us the Kconfig, or maybe I just miss some obstacle?
https://review.coreboot.org/#/c/22979/5/src/southbridge/intel/common/acpi_pi... File src/southbridge/intel/common/acpi_pirq_gen.c:
https://review.coreboot.org/#/c/22979/5/src/southbridge/intel/common/acpi_pi... PS5, Line 59: int_pin < 3 close
https://review.coreboot.org/#/c/22979/5/src/southbridge/intel/common/acpi_pi... PS5, Line 68: (pirq - PIRQ_A) Maybe it fits one line if you remove the parentheses...
https://review.coreboot.org/#/c/22979/5/src/southbridge/intel/common/rcba_pi... File src/southbridge/intel/common/rcba_pirq.c:
https://review.coreboot.org/#/c/22979/5/src/southbridge/intel/common/rcba_pi... PS5, Line 46: pci_pin cast to `enum pirq`?
-
Nico Huber (Code Review)