Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38640 )
Change subject: cpu: Allow to configure microcode at pre-defined address
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38640/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38640/6//COMMIT_MSG@7
PS6, Line 7: c
ah, now I understand what you meant. Sorry for being so tone-deaf. I believe it may be a good approach (having assembly code load ucode). I do not think it is really necessary to load ucode specifically with assembly before CAR is set up. I'd guess the only reason why would want to do it is that microcode fix is required for CAR to function properly.
It's actually pretty common to require microcode updates for CAR to function properly.
Anyway, for now we have to use FSP-T but like I said we are planning on changing that.
Sounds like a better plan than to hack around FSP-T requirements.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c02601a7ac64078e556e2032baeccaf27f77da2
Gerrit-Change-Number: 38640
Gerrit-PatchSet: 9
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 19 Feb 2020 11:45:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Andrey Petrov
anpetrov@fb.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment