Hello HAOUAS Elyes, Michał Żygowski, Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/38033
to review the following change.
Change subject: amd/acpi: Drop empty PCSD device nodes ......................................................................
amd/acpi: Drop empty PCSD device nodes
These devices were just added in 727ac0d263 (AMD {SoC, AGESA, binaryPI}: Don't use both of _ADR and _HID), but they don't provide any information and are not referenced anywhere.
Change-Id: I862a3c43eb610e488eb7d9246feb94a6d1333ca0 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/northbridge/amd/agesa/family14/acpi/northbridge.asl M src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl M src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl M src/northbridge/amd/pi/00630F01/acpi/northbridge.asl M src/northbridge/amd/pi/00660F01/acpi/northbridge.asl M src/northbridge/amd/pi/00730F01/acpi/northbridge.asl M src/soc/amd/picasso/acpi/northbridge.asl M src/soc/amd/stoneyridge/acpi/northbridge.asl 8 files changed, 0 insertions(+), 32 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/38033/1
diff --git a/src/northbridge/amd/agesa/family14/acpi/northbridge.asl b/src/northbridge/amd/agesa/family14/acpi/northbridge.asl index 6e3bc93..8130791 100644 --- a/src/northbridge/amd/agesa/family14/acpi/northbridge.asl +++ b/src/northbridge/amd/agesa/family14/acpi/northbridge.asl @@ -24,10 +24,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* The internal GFX bridge */ Device(AGPB) { Name(_ADR, 0x00010000) diff --git a/src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl b/src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl index f679234..c360da6 100644 --- a/src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl +++ b/src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl @@ -44,10 +44,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Dev2 is also an external GFX bridge */ Device(PBR2) { Name(_ADR, 0x00020000) diff --git a/src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl b/src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl index 3300db0..ce889c7 100644 --- a/src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl +++ b/src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl @@ -44,10 +44,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Gpp 0 */ Device(PBR4) { Name(_ADR, 0x00020001) diff --git a/src/northbridge/amd/pi/00630F01/acpi/northbridge.asl b/src/northbridge/amd/pi/00630F01/acpi/northbridge.asl index f3d42fa..ffe1367 100644 --- a/src/northbridge/amd/pi/00630F01/acpi/northbridge.asl +++ b/src/northbridge/amd/pi/00630F01/acpi/northbridge.asl @@ -44,10 +44,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Dev2 is also an external GFX bridge */ Device(PBR2) { Name(_ADR, 0x00020000) diff --git a/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl b/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl index 761ff44..28e2224 100644 --- a/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl +++ b/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl @@ -44,10 +44,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Gpp 0 */ Device(PBR4) { Name(_ADR, 0x00020001) diff --git a/src/northbridge/amd/pi/00730F01/acpi/northbridge.asl b/src/northbridge/amd/pi/00730F01/acpi/northbridge.asl index 3300db0..ce889c7 100644 --- a/src/northbridge/amd/pi/00730F01/acpi/northbridge.asl +++ b/src/northbridge/amd/pi/00730F01/acpi/northbridge.asl @@ -44,10 +44,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Gpp 0 */ Device(PBR4) { Name(_ADR, 0x00020001) diff --git a/src/soc/amd/picasso/acpi/northbridge.asl b/src/soc/amd/picasso/acpi/northbridge.asl index b1c2d31..208ea26 100644 --- a/src/soc/amd/picasso/acpi/northbridge.asl +++ b/src/soc/amd/picasso/acpi/northbridge.asl @@ -45,10 +45,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Internal Graphics */ Device(IGFX) { Name(_ADR, 0x00010000) diff --git a/src/soc/amd/stoneyridge/acpi/northbridge.asl b/src/soc/amd/stoneyridge/acpi/northbridge.asl index b1c2d31..208ea26 100644 --- a/src/soc/amd/stoneyridge/acpi/northbridge.asl +++ b/src/soc/amd/stoneyridge/acpi/northbridge.asl @@ -45,10 +45,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Internal Graphics */ Device(IGFX) { Name(_ADR, 0x00010000)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38033 )
Change subject: amd/acpi: Drop empty PCSD device nodes ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38033 )
Change subject: amd/acpi: Drop empty PCSD device nodes ......................................................................
amd/acpi: Drop empty PCSD device nodes
These devices were just added in 727ac0d263 (AMD {SoC, AGESA, binaryPI}: Don't use both of _ADR and _HID), but they don't provide any information and are not referenced anywhere.
Change-Id: I862a3c43eb610e488eb7d9246feb94a6d1333ca0 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/38033 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/amd/agesa/family14/acpi/northbridge.asl M src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl M src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl M src/northbridge/amd/pi/00630F01/acpi/northbridge.asl M src/northbridge/amd/pi/00660F01/acpi/northbridge.asl M src/northbridge/amd/pi/00730F01/acpi/northbridge.asl M src/soc/amd/picasso/acpi/northbridge.asl M src/soc/amd/stoneyridge/acpi/northbridge.asl 8 files changed, 0 insertions(+), 32 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/amd/agesa/family14/acpi/northbridge.asl b/src/northbridge/amd/agesa/family14/acpi/northbridge.asl index 6e3bc93..8130791 100644 --- a/src/northbridge/amd/agesa/family14/acpi/northbridge.asl +++ b/src/northbridge/amd/agesa/family14/acpi/northbridge.asl @@ -24,10 +24,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* The internal GFX bridge */ Device(AGPB) { Name(_ADR, 0x00010000) diff --git a/src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl b/src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl index f679234..c360da6 100644 --- a/src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl +++ b/src/northbridge/amd/agesa/family15tn/acpi/northbridge.asl @@ -44,10 +44,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Dev2 is also an external GFX bridge */ Device(PBR2) { Name(_ADR, 0x00020000) diff --git a/src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl b/src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl index 3300db0..ce889c7 100644 --- a/src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl +++ b/src/northbridge/amd/agesa/family16kb/acpi/northbridge.asl @@ -44,10 +44,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Gpp 0 */ Device(PBR4) { Name(_ADR, 0x00020001) diff --git a/src/northbridge/amd/pi/00630F01/acpi/northbridge.asl b/src/northbridge/amd/pi/00630F01/acpi/northbridge.asl index f3d42fa..ffe1367 100644 --- a/src/northbridge/amd/pi/00630F01/acpi/northbridge.asl +++ b/src/northbridge/amd/pi/00630F01/acpi/northbridge.asl @@ -44,10 +44,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Dev2 is also an external GFX bridge */ Device(PBR2) { Name(_ADR, 0x00020000) diff --git a/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl b/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl index 761ff44..28e2224 100644 --- a/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl +++ b/src/northbridge/amd/pi/00660F01/acpi/northbridge.asl @@ -44,10 +44,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Gpp 0 */ Device(PBR4) { Name(_ADR, 0x00020001) diff --git a/src/northbridge/amd/pi/00730F01/acpi/northbridge.asl b/src/northbridge/amd/pi/00730F01/acpi/northbridge.asl index 3300db0..ce889c7 100644 --- a/src/northbridge/amd/pi/00730F01/acpi/northbridge.asl +++ b/src/northbridge/amd/pi/00730F01/acpi/northbridge.asl @@ -44,10 +44,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Gpp 0 */ Device(PBR4) { Name(_ADR, 0x00020001) diff --git a/src/soc/amd/picasso/acpi/northbridge.asl b/src/soc/amd/picasso/acpi/northbridge.asl index b1c2d31..208ea26 100644 --- a/src/soc/amd/picasso/acpi/northbridge.asl +++ b/src/soc/amd/picasso/acpi/northbridge.asl @@ -45,10 +45,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Internal Graphics */ Device(IGFX) { Name(_ADR, 0x00010000) diff --git a/src/soc/amd/stoneyridge/acpi/northbridge.asl b/src/soc/amd/stoneyridge/acpi/northbridge.asl index b1c2d31..208ea26 100644 --- a/src/soc/amd/stoneyridge/acpi/northbridge.asl +++ b/src/soc/amd/stoneyridge/acpi/northbridge.asl @@ -45,10 +45,6 @@ Name(_ADR, 0x00000000) } /* end AMRT */
-Device(PCSD) { /* Processor configuration space devices */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ -} - /* Internal Graphics */ Device(IGFX) { Name(_ADR, 0x00010000)
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)