Change in coreboot[master]: mb/google/dedede/var/bugzzy: Initialize display signals on user mode

[Paul Menzel (Code Review)]

Attention is currently required from: shkim, Henry Sun, SH Kim, Edward Doan, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 )

Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
......................................................................

Patch Set 4:

(10 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/60190/comment/30f6aee3_bf3da396 
PS4, Line 19: new touch screen firmware
Which version exactly?

https://review.coreboot.org/c/coreboot/+/60190/comment/b82336cc_0b45853c 
PS4, Line 20: 
Please add the delay the current code adds. Seems like over 100 ms?

File src/mainboard/google/dedede/variants/bugzzy/ramstage.c:

https://review.coreboot.org/c/coreboot/+/60190/comment/90a62cbf_cbea63c7 
PS4, Line 17:  * Bugzzy uses panel-built-in touch screen, it needs
            :  * to set panel power and reset signal to high for touch
            :  * screen to work.
            :  * On user mode, coreboot doesn't initialize graphics
            :  * since there is no screen display before OS. We would
            :  * add this WA to initialize required signals on user mode.
Please reflow for 80 (or 96) characters per line.

https://review.coreboot.org/c/coreboot/+/60190/comment/6d7d556c_44c16c9f 
PS4, Line 33: 	addr32 = 0xc0010000; // IGD MMIO BASE
Add define or enum?

https://review.coreboot.org/c/coreboot/+/60190/comment/bdc6920a_1aac7598 
PS4, Line 37:  // clear bit3 ~ bit0
Not needed.

https://review.coreboot.org/c/coreboot/+/60190/comment/150e55b7_6a9a3866 
PS4, Line 47: 	udelay(20 * 1000); // delay 20ms
Please mention the datasheet name, revision and section requiring this. The current comment is not needed.

https://review.coreboot.org/c/coreboot/+/60190/comment/197a94d9_bcfa91b9 
PS4, Line 47: udelay(20 * 1000);
mdelay(20)

https://review.coreboot.org/c/coreboot/+/60190/comment/b71e0bdb_82c8e748 
PS4, Line 49: 	//reset high
Space after //.

https://review.coreboot.org/c/coreboot/+/60190/comment/cbf7a5ae_82e5e797 
PS4, Line 59: 	//reset low
Ditto.

https://review.coreboot.org/c/coreboot/+/60190/comment/3ca2293a_6014e871 
PS4, Line 69: 	//reset high
Ditto.