Attention is currently required from: Chris Ching.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22822 )
Change subject: ic2/designware: Move Intel i2c logic to shared driver
......................................................................
Patch Set 9:
(2 comments)
File src/drivers/i2c/designware/dw_i2c.h:
https://review.coreboot.org/c/coreboot/+/22822/comment/1571c337_52df5d7a
PS8, Line 47: familuar
Misplaced comment?
CB:23714 fixed it
File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/22822/comment/06b89a41_bd04534d
PS9, Line 609: /* If rise time is set use the time calculation. */
I guess I want to say that if I saw rise_time_ns copy-pasted between variants, I would suggest rem […]
If rise_fall_time() with .rise_time_ns==0 is better than the results with rest of the function here, remove the conditional?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/22822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb453a4d2411163e6b4a8422310bf272eac5d379
Gerrit-Change-Number: 22822
Gerrit-PatchSet: 9
Gerrit-Owner: Chris Ching
chingcodes@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Ching
chingcodes@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Chris Ching
chingcodes@chromium.org
Gerrit-Comment-Date: Tue, 09 Mar 2021 09:50:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment