Attention is currently required from: Arthur Heymans, Raul Rangel, Tristan Corrick, Tim Wawrzynczak, Alexander Couzens, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59314 )
Change subject: cpu/intel/haswell: Move chip_ops to cpu cluster
......................................................................
Patch Set 12: Code-Review+1
(1 comment)
File src/northbridge/intel/haswell/northbridge.c:
https://review.coreboot.org/c/coreboot/+/59314/comment/58dda4c9_dde1750d
PS12, Line 559: struct device_operations haswell_cpu_bus_ops = {
: .read_resources = noop_read_resources,
: .set_resources = noop_set_resources,
: .init = mp_cpu_bus_init,
: .acpi_fill_ssdt = generate_cpu_entries,
: };
Could we move this struct to `cpu/intel/haswell`? It would avoid having two redundant structs (Haswell and Broadwell use `cpu/intel/haswell` code).
We can do this as a follow-up if you prefer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59314
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic449b2df8036e8c02b5559cca6b2e7479a70a786
Gerrit-Change-Number: 59314
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 11 Nov 2022 15:06:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment