Change in coreboot[master]: libpayload/libpci: Store device class in pci_dev

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Felix Singer (Code Review)

13 Oct 2020 13 Oct '20

6:06 p.m.

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46347 )

Change subject: libpayload/libpci: Store device class in pci_dev ......................................................................

libpayload/libpci: Store device class in pci_dev

Change-Id: I5d56be96f3f0da471246f031ea619e3df8e54cfb Signed-off-by: Felix Singer felix.singer@secunet.com --- M payloads/libpayload/include/pci/pci.h M payloads/libpayload/libpci/libpci.c 2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/46347/1

diff --git a/payloads/libpayload/include/pci/pci.h b/payloads/libpayload/include/pci/pci.h index 37aeafa..ea11a05 100644 --- a/payloads/libpayload/include/pci/pci.h +++ b/payloads/libpayload/include/pci/pci.h @@ -74,6 +74,7 @@ u16 domain; u8 bus, dev, func; u16 vendor_id, device_id; + u16 device_class; struct pci_dev *parent; struct pci_dev *next; }; diff --git a/payloads/libpayload/libpci/libpci.c b/payloads/libpayload/libpci/libpci.c index 50cd228..b8188a1 100644 --- a/payloads/libpayload/libpci/libpci.c +++ b/payloads/libpayload/libpci/libpci.c @@ -182,6 +182,7 @@ dev->func = func; dev->vendor_id = val & 0xffff; dev->device_id = (uint16_t)(val >> 16); + dev->device_class = pci_read_config16(PCI_DEV(bus, slot, func), 0xa); dev->next = 0;

hdr = pci_read_config8(PCI_DEV(bus, slot, func),

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Angel Pons (Code Review)

13 Oct 13 Oct

7:11 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46347 )

Change subject: libpayload/libpci: Store device class in pci_dev ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/46347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d56be96f3f0da471246f031ea619e3df8e54cfb Gerrit-Change-Number: 46347 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 13 Oct 2020 17:11:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Singer (Code Review)

14 Oct 14 Oct

6:51 p.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46347

to look at the new patch set (#2).

Change subject: libpayload/libpci: Store device class in pci_dev ......................................................................

libpayload/libpci: Store device class in pci_dev

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/46347/2

build bot (Jenkins) (Code Review)

6:51 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46347 )

Change subject: libpayload/libpci: Store device class in pci_dev ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46347/2/payloads/libpayload/libpci/... File payloads/libpayload/libpci/libpci.c:

https://review.coreboot.org/c/coreboot/+/46347/2/payloads/libpayload/libpci/... PS2, Line 185: dev->device_class = pci_read_config16(PCI_DEV(bus, slot, func), PCI_CLASS_DEVICE); line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/46347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d56be96f3f0da471246f031ea619e3df8e54cfb Gerrit-Change-Number: 46347 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 14 Oct 2020 16:51:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Singer (Code Review)

15 Oct 15 Oct

11:12 p.m.

New subject: Change in coreboot[master]: libpayload/libpci: Introduce device class attribute in pci_dev

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46347 )

Change subject: libpayload/libpci: Introduce device class attribute in pci_dev ......................................................................

Set Ready For Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/46347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d56be96f3f0da471246f031ea619e3df8e54cfb Gerrit-Change-Number: 46347 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 15 Oct 2020 21:12:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

17 Oct 17 Oct

1:29 a.m.

New subject: Change in coreboot[master]: libpayload/libpci: Introduce device class attribute in pci_dev

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46347 )

Change subject: libpayload/libpci: Introduce device class attribute in pci_dev ......................................................................

Patch Set 6: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/46347/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46347/6//COMMIT_MSG@10 PS6, Line 10: preperation preparation

-- To view, visit https://review.coreboot.org/c/coreboot/+/46347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d56be96f3f0da471246f031ea619e3df8e54cfb Gerrit-Change-Number: 46347 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 16 Oct 2020 23:29:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Singer (Code Review)

6:29 p.m.

New subject: Change in coreboot[master]: libpayload/libpci: Introduce device class attribute in pci_dev

Hello build bot (Jenkins), Nico Huber, Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46347

to look at the new patch set (#7).

Change subject: libpayload/libpci: Introduce device class attribute in pci_dev ......................................................................

libpayload/libpci: Introduce device class attribute in pci_dev

The device class is read at different places and it is read from the hardware directly. Therefore, and in preparation to CB:46416, introduce the device class attribute in the pci_dev struct. With this, there is only one interaction with the hardware and it's also more user friendly.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/46347/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/46347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d56be96f3f0da471246f031ea619e3df8e54cfb Gerrit-Change-Number: 46347 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

6:29 p.m.

New subject: Change in coreboot[master]: libpayload/libpci: Introduce device class attribute in pci_dev

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46347 )

Change subject: libpayload/libpci: Introduce device class attribute in pci_dev ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46347/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46347/6//COMMIT_MSG@10 PS6, Line 10: preperation

...

preparation

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d56be96f3f0da471246f031ea619e3df8e54cfb Gerrit-Change-Number: 46347 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 17 Oct 2020 16:29:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Nico Huber (Code Review)

6:33 p.m.

New subject: Change in coreboot[master]: libpayload/libpci: Introduce device class attribute in pci_dev

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46347 )

Change subject: libpayload/libpci: Introduce device class attribute in pci_dev ......................................................................

libpayload/libpci: Introduce device class attribute in pci_dev

Change-Id: I5d56be96f3f0da471246f031ea619e3df8e54cfb Signed-off-by: Felix Singer felix.singer@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46347 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M payloads/libpayload/include/pci/pci.h M payloads/libpayload/libpci/libpci.c 2 files changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved

diff --git a/payloads/libpayload/include/pci/pci.h b/payloads/libpayload/include/pci/pci.h index 8c11d6b..7ec9491 100644 --- a/payloads/libpayload/include/pci/pci.h +++ b/payloads/libpayload/include/pci/pci.h @@ -74,6 +74,7 @@ u16 domain; u8 bus, dev, func; u16 vendor_id, device_id; + u16 device_class; struct pci_dev *next; };

diff --git a/payloads/libpayload/libpci/libpci.c b/payloads/libpayload/libpci/libpci.c index 3e3513c..200ae18 100644 --- a/payloads/libpayload/libpci/libpci.c +++ b/payloads/libpayload/libpci/libpci.c @@ -178,6 +178,7 @@ dev->func = func; dev->vendor_id = val & 0xffff; dev->device_id = (uint16_t)(val >> 16); + dev->device_class = pci_read_config16(PCI_DEV(bus, slot, func), PCI_CLASS_DEVICE); dev->next = 0;

hdr = pci_read_config8(PCI_DEV(bus, slot, func),

-- To view, visit https://review.coreboot.org/c/coreboot/+/46347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d56be96f3f0da471246f031ea619e3df8e54cfb Gerrit-Change-Number: 46347 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1554

days inactive

1558

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
build bot (Jenkins) (Code Review)
Felix Singer (Code Review)
Nico Huber (Code Review)