Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29077 )
Change subject: security/vboot: Drop `depends on HAVE_HARD_RESET`
......................................................................
Patch Set 2:
(1 comment)
Patch Set 2: Code-Review-2
Doesn't make sense to me to add FIXME all over the place. Also HAVE HARD RESET is unrelated to this
I agree. There's no need for a -2, though: unresolved comments already prevent accidentally submitting this.
https://review.coreboot.org/c/coreboot/+/29077/2/src/mainboard/google/auron/...
File src/mainboard/google/auron/Kconfig:
https://review.coreboot.org/c/coreboot/+/29077/2/src/mainboard/google/auron/...
PS2, Line 22: # FIXME: Predefining VBOOT breaks Kconfigs dependencies.
: # Please use proper `select ... if VBOOT` instead.
I didn't know how to convince `sed` to do it. […]
You might try to bribe me into doing it for you
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29077
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0e0bcf7d5a662a526ce20f0a6d9cfeb8fafe7fe
Gerrit-Change-Number: 29077
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Thu, 23 Jul 2020 12:40:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment