Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69062 )
Change subject: drivers/i2c/generic: Tweak error text for missing HID ......................................................................
drivers/i2c/generic: Tweak error text for missing HID
- drop ERROR prefix since already provided by cbmem log - make error text more clear about cause of error
BUG=none
Change-Id: I1795aee240a5383b21108c697e930a2e4972a0b4 Signed-off-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/69062 Reviewed-by: Raul Rangel rrangel@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/i2c/generic/generic.c 1 file changed, 19 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 872891b..981c2d9 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -62,7 +62,7 @@ return;
if (!config->hid) { - printk(BIOS_ERR, "%s: ERROR: HID required\n", dev_path(dev)); + printk(BIOS_ERR, "%s: HID required but not set\n", dev_path(dev)); return; }