Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39895 )
Change subject: mb/ocp/tiogapass: Update UPD IIO bifurcation at run-time ......................................................................
Patch Set 7:
(6 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/39895/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39895/6//COMMIT_MSG@9 PS6, Line 9: accroding
according
Done
https://review.coreboot.org/c/coreboot/+/39895/6//COMMIT_MSG@13 PS6, Line 13: need
needs
Done
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/romstage.c:
https://review.coreboot.org/c/coreboot/+/39895/5/src/mainboard/ocp/tiogapass... PS5, Line 28: * Read GPIO, SMBUS data or IPMI command to decide : * IIO bifurcation at run-time.
ok. […]
I reply to the last change at https://review.coreboot.org/c/coreboot/+/40021/1
https://review.coreboot.org/c/coreboot/+/39895/6/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/romstage.c:
https://review.coreboot.org/c/coreboot/+/39895/6/src/mainboard/ocp/tiogapass... PS6, Line 28: SMBUS
SMBus
Done
https://review.coreboot.org/c/coreboot/+/39895/6/src/mainboard/ocp/tiogapass... PS6, Line 29: * IIO bifurcation at run-time.
Should fit in 96 characters.
Done
https://review.coreboot.org/c/coreboot/+/39895/6/src/mainboard/ocp/tiogapass... PS6, Line 32: */
Please use one of the allowed comment styles. […]
Done
-
Johnny Lin (Code Review)