Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/25410
Change subject: Add Pipe_Index to the Connectors.Post_On method ......................................................................
Add Pipe_Index to the Connectors.Post_On method
On GMCH targets the Pipe index needs to be programmed in the output register.
Change-Id: I6a614a9359c95adb59a1b6d0e34febe302fcfbf8 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M common/haswell_shared/hw-gfx-gma-connectors.adb M common/hw-gfx-gma-connectors.ads M common/hw-gfx-gma.adb M common/ironlake/hw-gfx-gma-connectors.adb 4 files changed, 8 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/10/25410/1
diff --git a/common/haswell_shared/hw-gfx-gma-connectors.adb b/common/haswell_shared/hw-gfx-gma-connectors.adb index 0aed750..6d5ec52 100644 --- a/common/haswell_shared/hw-gfx-gma-connectors.adb +++ b/common/haswell_shared/hw-gfx-gma-connectors.adb @@ -49,7 +49,8 @@ end Pre_On;
procedure Post_On - (Port_Cfg : in Port_Config; + (Pipe : in Pipe_Index; + Port_Cfg : in Port_Config; PLL_Hint : in Word32; Success : out Boolean) is diff --git a/common/hw-gfx-gma-connectors.ads b/common/hw-gfx-gma-connectors.ads index 134b076..a1d0d1e 100644 --- a/common/hw-gfx-gma-connectors.ads +++ b/common/hw-gfx-gma-connectors.ads @@ -29,7 +29,8 @@ Success : out Boolean);
procedure Post_On - (Port_Cfg : in Port_Config; + (Pipe : in Pipe_Index; + Port_Cfg : in Port_Config; PLL_Hint : in Word32; Success : out Boolean); pragma Warnings (GNATprove, On, "unused variable ""P*"""); diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index a4445ba..d6aa7cb 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -150,7 +150,8 @@ Framebuffer => Pipe_Cfg.Framebuffer);
Connectors.Post_On - (Port_Cfg => Port_Cfg, + (Pipe => Pipe, + Port_Cfg => Port_Cfg, PLL_Hint => PLLs.Register_Value (Allocated_PLLs (Pipe)), Success => Success);
diff --git a/common/ironlake/hw-gfx-gma-connectors.adb b/common/ironlake/hw-gfx-gma-connectors.adb index f18f64f..9bb0b68 100644 --- a/common/ironlake/hw-gfx-gma-connectors.adb +++ b/common/ironlake/hw-gfx-gma-connectors.adb @@ -60,7 +60,8 @@ end Pre_On;
procedure Post_On - (Port_Cfg : in Port_Config; + (Pipe : in Pipe_Index; + Port_Cfg : in Port_Config; PLL_Hint : in Word32; Success : out Boolean) is