Change in coreboot[master]: soc/mediatek: Add early_init for passing data across sessions
Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Angel Pons, Yu-Ping Wu. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63019 )
Change subject: soc/mediatek: Add early_init for passing data across sessions ......................................................................
Patch Set 5:
(4 comments)
File src/soc/mediatek/common/early_init.c:
https://review.coreboot.org/c/coreboot/+/63019/comment/180508e8_2b182d59 PS4, Line 42: if (!init->saved_time[init_type].microseconds)
shouldn't access microsecond field directly. […]
Done
https://review.coreboot.org/c/coreboot/+/63019/comment/4c044575_eaabbf57 PS4, Line 45: timer_monotonic_get(&init->cur_time[init_type]);
cur_time doesn't need to be in the struct. A local variable can be used.
Done
File src/soc/mediatek/common/include/soc/early_init.h:
https://review.coreboot.org/c/coreboot/+/63019/comment/cdd47f39_14d88483 PS4, Line 13: enum early_init_types {
I'd prefer "type" without "s"
Done
File src/soc/mediatek/common/include/soc/early_init.h:
https://review.coreboot.org/c/coreboot/+/63019/comment/d5bbba70_5c6d6c04 PS1, Line 10: mtk_early_init
shouldn't we rename it to early_init_data?
Done
-
Jianjun Wang (Code Review)