Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74769 )
Change subject: soc/intel/meteorlake: Add support of crashlog ......................................................................
Patch Set 14:
(7 comments)
Patchset:
PS14:
possible to split the common code and land that first and then push SoC specific code (aka MTL?) […]
It's better to keep this change as a single CL. Common code is changed in such a way that it won't affect ADL. I am adding some new comments in the common code to help understand the changes.
File src/soc/intel/common/block/acpi/acpi_bert.c:
https://review.coreboot.org/c/coreboot/+/74769/comment/8a3aa7b7_b0e9b3a9 PS14, Line 90: cl_get_ioe_record_size default implementation (using _weak) of this in common code returns zero, so it should not affect overall flow for previous gen of Intel SOCs.
File src/soc/intel/common/block/crashlog/crashlog.c:
https://review.coreboot.org/c/coreboot/+/74769/comment/af799f5a_d64029bf PS14, Line 293: INVALID_CL this case should be checked for all Intel SOCs, so i have added in common code.
https://review.coreboot.org/c/coreboot/+/74769/comment/0f736546_0b31593d PS14, Line 507: cl_src_addr This is just to make sure cbmem exists. This will not affect prev gen of Intel SOC code. Same for other cl_fill* methods below.
https://review.coreboot.org/c/coreboot/+/74769/comment/7713f554_a999e054 PS14, Line 542: cl_get_ioe_record_size default implementation in common code returns zero, so no effect on other SOC specific code.
File src/soc/intel/common/block/include/intelblocks/crashlog.h:
https://review.coreboot.org/c/coreboot/+/74769/comment/f3d6cadb_3b520741 PS14, Line 35: size Keeping size to 13bits will still keep it compatible for prev gen of Intel SOCs. So we can have this change in common code area.
https://review.coreboot.org/c/coreboot/+/74769/comment/bd0cdfd9_1c697379 PS14, Line 160: size size is increased to 32bits. This will be still backwards compatible to prev gen.
-
Pratikkumar V Prajapati (Code Review)