Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38824 )
Change subject: soc/intel/apollolake: Display platform information ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38824/4/src/soc/intel/apollolake/re... File src/soc/intel/apollolake/report_platform.c:
https://review.coreboot.org/c/coreboot/+/38824/4/src/soc/intel/apollolake/re... PS4, Line 79: u32 i
This was missed. I’d make all counting variables `unsigned int`.
Yes i have made all the counting variables `unsigned int`in the new patch set
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re... File src/soc/intel/apollolake/report_platform.c:
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re... PS6, Line 106: aes_supported = (cpu_feature_flag & CPUID_AES) ? 1 : 0;
Use true and false? Do you need a ternary operator?
The value 0 or 1 is being used as an array index into mode[], so do not want to use boolean representation here. Hence would like to make vt_supported, txt_supported, aes_supported as int itself.
-
Usha P (Code Review)